Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/favicon/favicon_handler_unittest.cc

Issue 10765021: Make the id used in IconMsg_DownloadFavicon unique (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_handler_delegate.h ('k') | chrome/browser/favicon/favicon_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler_unittest.cc
diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc
index bdfdcbb4d7a2147f95bd9c46b83bdb5ac0a7b51a..43eb49f3371359b4a4b65fc6105bebb7dca447c4 100644
--- a/chrome/browser/favicon/favicon_handler_unittest.cc
+++ b/chrome/browser/favicon/favicon_handler_unittest.cc
@@ -152,9 +152,10 @@ class TestFaviconHandlerDelegate : public FaviconHandlerDelegate {
return NULL;
}
- virtual void StartDownload(int id, const GURL& url, int image_size) {
+ virtual int StartDownload(const GURL& url, int image_size) {
ADD_FAILURE() << "TestFaviconHandlerDelegate::StartDownload() "
<< "should never be called in tests.";
+ return -1;
}
virtual void NotifyFaviconUpdated() {
« no previous file with comments | « chrome/browser/favicon/favicon_handler_delegate.h ('k') | chrome/browser/favicon/favicon_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698