Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2033)

Unified Diff: chrome/browser/favicon/favicon_handler_delegate.h

Issue 10765021: Make the id used in IconMsg_DownloadFavicon unique (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_handler.cc ('k') | chrome/browser/favicon/favicon_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler_delegate.h
diff --git a/chrome/browser/favicon/favicon_handler_delegate.h b/chrome/browser/favicon/favicon_handler_delegate.h
index 789f9e6f275d97900c7133da7d1e1f6a54126696..e0ff489faa9393558ab08158c538694ffdaea2e6 100644
--- a/chrome/browser/favicon/favicon_handler_delegate.h
+++ b/chrome/browser/favicon/favicon_handler_delegate.h
@@ -19,9 +19,11 @@ class FaviconHandlerDelegate {
// Returns the current NavigationEntry.
virtual content::NavigationEntry* GetActiveEntry() = 0;
- // Starts the download for the given favicon. When finished, the delegate
- // will call |OnDidDownloadFavicon()| with the results.
- virtual void StartDownload(int id, const GURL& url, int image_size) = 0;
+ // Starts the download for the given favicon. When finished, the delegate
+ // will call OnDidDownloadFavicon() with the results.
+ // Returns the unique id of the download request. The id will be passed
+ // in OnDidDownloadFavicon().
+ virtual int StartDownload(const GURL& url, int image_size) = 0;
// Notifies the delegate that the favicon for the active entry was updated.
virtual void NotifyFaviconUpdated() = 0;
« no previous file with comments | « chrome/browser/favicon/favicon_handler.cc ('k') | chrome/browser/favicon/favicon_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698