Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 10765020: gdata: Simplify semantics of sub_dir_type in CacheEntry. (Closed)

Created:
8 years, 5 months ago by satorux1
Modified:
8 years, 5 months ago
Reviewers:
hshi1
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Simplify semantics of sub_dir_type in CacheEntry. Previously, CACHE_TYPE_PINNED was set when the file was pinned but not yet fetched. This is awkward as the cache file is stored in either 'tmp' or 'persistent' directory. This is in preparation of removing sub_dir_type member from CacheEntry, which is in preparation of removing 'pinned' and 'outgoing' directories. This is yet another yak to shave. BUG=136390 TEST=out/Release/unit_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145844

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
chrome/browser/chromeos/gdata/gdata_cache.cc View 1 chunk +3 lines, -4 lines 0 comments Download
chrome/browser/chromeos/gdata/gdata_cache_metadata.cc View 3 chunks +7 lines, -1 line 0 comments Download
chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc View 2 chunks +3 lines, -3 lines 2 comments Download
chrome/browser/chromeos/gdata/gdata_cache_unittest.cc View 7 chunks +9 lines, -8 lines 0 comments Download
chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
8 years, 5 months ago (2012-07-10 00:11:06 UTC) #1
hshi1
http://codereview.chromium.org/10765020/diff/1/chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc File chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc (right): http://codereview.chromium.org/10765020/diff/1/chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc#newcode377 chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc:377: GDataCache::CACHE_TYPE_PERSISTENT, This seems to be the only line of ...
8 years, 5 months ago (2012-07-10 00:45:53 UTC) #2
satorux1
http://codereview.chromium.org/10765020/diff/1/chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc File chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc (right): http://codereview.chromium.org/10765020/diff/1/chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc#newcode377 chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc:377: GDataCache::CACHE_TYPE_PERSISTENT, On 2012/07/10 00:45:53, hshi1 wrote: > This seems ...
8 years, 5 months ago (2012-07-10 03:18:56 UTC) #3
ivan_cobs.com.sg
Pls remove the following email adds from your list NOW ivan@cobs.com.sg lynn@cobs.com.sg -----Original Message----- From: ...
8 years, 5 months ago (2012-07-10 03:48:22 UTC) #4
hshi1
8 years, 5 months ago (2012-07-10 04:34:40 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698