chrome/common/extensions/permissions/permission_set.cc - Issue 10765014: [Coverity] Fix pass-by-val/pass-by-ref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permission_set.cc

Issue 10765014: [Coverity] Fix pass-by-val/pass-by-ref (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/permissions/permission_set.cc

diff --git a/chrome/common/extensions/permissions/permission_set.cc b/chrome/common/extensions/permissions/permission_set.cc

index eb52931e6c4c3c65b3419f5cdf1fd128d97603f7..019504dff8fea208727411eadf1fd584574e7652 100644

--- a/chrome/common/extensions/permissions/permission_set.cc

+++ b/chrome/common/extensions/permissions/permission_set.cc

@@ -20,7 +20,7 @@

namespace {

// Helper for GetDistinctHosts(): com > net > org > everything else.

-bool RcdBetterThan(std::string a, std::string b) {

+bool RcdBetterThan(const std::string& a, const std::string& b) {

if (a == b)

return false;

if (a == "com")

« no previous file with comments | « no previous file | no next file » | no next file with comments »