Add scoped StartupInfoEx to base.

Add scoped StartupInfoEx to base.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145901

[jschuh, 2012-07-09 20:18:07]

I didn't want to do this, but Windows made me.

[brettw, 2012-07-10 05:41:24]

lgtm

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
File base/win/scoped_startup_info_ex.cc (right):

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
base/win/scoped_startup_info_ex.cc:32: static
DeleteProcThreadAttributeListFunction s_DeleteProcThreadAttributeList;
I've never seen "s_..." notation. I'd probably name this like a local var
(delete_proc_thread...) even though it's weird.

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
base/win/scoped_startup_info_ex.cc:89: delete []
reinterpret_cast<BYTE*>(startup_info_.lpAttributeList);
I think you need to set the list to null after this.

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
File base/win/scoped_startup_info_ex.h (right):

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
base/win/scoped_startup_info_ex.h:28: bool UpdateProcThreadAttribute(DWORD_PTR
attribute,
What were they smoking when they made this a DWORD_PTR?

[jschuh, 2012-07-10 16:14:50]

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
File base/win/scoped_startup_info_ex.cc (right):

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
base/win/scoped_startup_info_ex.cc:32: static
DeleteProcThreadAttributeListFunction s_DeleteProcThreadAttributeList;
On 2012/07/10 05:41:24, brettw wrote:
> I've never seen "s_..." notation. I'd probably name this like a local var
> (delete_proc_thread...) even though it's weird.

Done.

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
base/win/scoped_startup_info_ex.cc:89: delete []
reinterpret_cast<BYTE*>(startup_info_.lpAttributeList);
On 2012/07/10 05:41:24, brettw wrote:
> I think you need to set the list to null after this.

Done.

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
File base/win/scoped_startup_info_ex.h (right):

https://chromiumcodereview.appspot.com/10765008/diff/9001/base/win/scoped_sta...
base/win/scoped_startup_info_ex.h:28: bool UpdateProcThreadAttribute(DWORD_PTR
attribute,
On 2012/07/10 05:41:24, brettw wrote:
> What were they smoking when they made this a DWORD_PTR?

Yep. Boggles the mind. Almost as funny, it's just a typedef for ULONG_PTR.

[commit-bot: I haz the power, 2012-07-10 16:15:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/10765008/12001

[commit-bot: I haz the power, 2012-07-10 17:35:54]

Change committed as 145901