Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 10764015: Ensure static BrowserContext methods only get called on the UI thread. (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
Reviewers:
awong
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Ensure static BrowserContext methods only get called on the UI thread. Also ensure ResourceContext methods only get called on the IO thread. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145944

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : use ajwong's cleaner fix in browsing_data_file_system_helper.cc #

Patch Set 4 : also try on ResourceContext #

Patch Set 5 : fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M chrome/browser/browsing_data_file_system_helper.cc View 1 2 5 chunks +10 lines, -14 lines 0 comments Download
M chrome/browser/browsing_data_file_system_helper_unittest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_context.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/resource_context_impl.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/browser/browser_context.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
8 years, 5 months ago (2012-07-10 17:05:14 UTC) #1
awong
LGTM though the stdio test is still failing with this patch. Since this was happening ...
8 years, 5 months ago (2012-07-10 17:42:55 UTC) #2
awong
I mean the "Empty" test, not stdio. On 2012/07/10 17:42:55, awong wrote: > LGTM > ...
8 years, 5 months ago (2012-07-10 17:43:23 UTC) #3
jam
On 2012/07/10 17:43:23, awong wrote: > I mean the "Empty" test, not stdio. > > ...
8 years, 5 months ago (2012-07-10 18:03:33 UTC) #4
awong
8 years, 5 months ago (2012-07-10 18:09:50 UTC) #5
LGTM++

Powered by Google App Engine
This is Rietveld 408576698