chrome/browser/ui/webui/print_preview/print_preview_handler.cc - Issue 10764009: Merge 145424 - Fix crash due to incorrectly parented window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 10764009: Merge 145424 - Fix crash due to incorrectly parented window (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

===================================================================

--- chrome/browser/ui/webui/print_preview/print_preview_handler.cc (revision 145763)

+++ chrome/browser/ui/webui/print_preview/print_preview_handler.cc (working copy)

@@ -546,7 +546,7 @@

void PrintPreviewHandler::HandleSignin(const ListValue* /*args*/) {

gfx::NativeWindow modal_parent =

- preview_web_contents()->GetView()->GetTopLevelNativeWindow();

+ platform_util::GetTopLevel(preview_web_contents()->GetNativeView());

print_dialog_cloud::CreateCloudPrintSigninDialog(

preview_web_contents()->GetBrowserContext(),

modal_parent,

@@ -570,7 +570,7 @@

DCHECK_GT(data->size(), 0U);

gfx::NativeWindow modal_parent =

- preview_web_contents()->GetView()->GetTopLevelNativeWindow();

+ platform_util::GetTopLevel(preview_web_contents()->GetNativeView());

print_dialog_cloud::CreatePrintDialogForBytes(

preview_web_contents()->GetBrowserContext(),

modal_parent,

« no previous file with comments | « no previous file | no next file » | no next file with comments »