Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: native_client_sdk/src/build_tools/update_nacl_manifest.py

Issue 10764002: [NaCl SDK] Set "recommended" tag to "yes" automatically for stable pepper bundle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/build_tools/tests/test_update_manifest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/update_nacl_manifest.py
diff --git a/native_client_sdk/src/build_tools/update_nacl_manifest.py b/native_client_sdk/src/build_tools/update_nacl_manifest.py
index 9f7af059498ba94cd17af97f1665c2461e868231..8147077e8009b2a03e434179bffcddc798375dd6 100755
--- a/native_client_sdk/src/build_tools/update_nacl_manifest.py
+++ b/native_client_sdk/src/build_tools/update_nacl_manifest.py
@@ -467,7 +467,6 @@ class Updater(object):
for bundle_name, version, channel, archives in self.versions_to_update:
self.delegate.Print('Updating %s to %s...' % (bundle_name, version))
bundle = manifest.GetBundle(bundle_name)
- bundle_recommended = bundle.recommended
for archive in archives:
platform_bundle = self._GetPlatformArchiveBundle(archive)
# Normally the manifest snippet's bundle name matches our bundle name.
@@ -476,7 +475,11 @@ class Updater(object):
platform_bundle.name = bundle_name
bundle.MergeWithBundle(platform_bundle)
bundle.stability = channel
- bundle.recommended = bundle_recommended
+ # We always recommend the stable version.
+ if channel == 'stable':
+ bundle.recommended = 'yes'
+ else:
+ bundle.recommended = 'no'
noelallen1 2012/07/09 21:58:39 Does the no mean we don't recommend anything but?
binji 2012/07/09 22:06:29 That's what I figured... I've pretty much been upd
manifest.MergeBundle(bundle)
self._UploadManifest(manifest)
self.delegate.Print('Done.')
« no previous file with comments | « native_client_sdk/src/build_tools/tests/test_update_manifest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698