Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 10763019: Fix ant build of content shell for updated Android SDK tools. (Closed)

Created:
8 years, 5 months ago by navabi
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix ant build of content shell for updated Android SDK tools. Since the update of tools/build.xml in the Android SDK the way jar files are included has been changed. This fix makes sure jar files are correctly used in the build of content shell. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M content/shell/android/java/content_shell_apk.xml View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
navabi
8 years, 5 months ago (2012-07-10 00:15:03 UTC) #1
John Grabowski
LGTM
8 years, 5 months ago (2012-07-10 00:23:03 UTC) #2
Yaron
lgtm
8 years, 5 months ago (2012-07-10 00:31:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/10763019/1
8 years, 5 months ago (2012-07-10 00:56:50 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 02:16:30 UTC) #5
Change committed as 145826

Powered by Google App Engine
This is Rietveld 408576698