Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10763009: Merge 144251 - Now doesn't wait to destroy non-incognito profiles, and allow immediate destruction … (Closed)

Created:
8 years, 5 months ago by MAD
Modified:
8 years, 5 months ago
Reviewers:
MAD
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 144251 - Now doesn't wait to destroy non-incognito profiles, and allow immediate destruction of incognito profiles from their parent profile. Also, doesn't wait infinitely for render process hosts to go away, uses a timer to complete destruction. And finally, adds DCHECKs to identify when render process hosts are dead soon enough. BUG=130772 TEST=Make sure Chrome exits without a crash and that Profile info properly got saved. Also make sure info doesn't leak from one incognito session to another. Review URL: https://chromiumcodereview.appspot.com/10645005 TBR=mad@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -11 lines) Patch
M chrome/browser/profiles/profile_destroyer.h View 4 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_destroyer.cc View 2 chunks +99 lines, -9 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
MAD
8 years, 5 months ago (2012-07-09 21:14:11 UTC) #1
MAD
8 years, 5 months ago (2012-07-09 21:22:34 UTC) #2
self-lgtm... ;-)

Powered by Google App Engine
This is Rietveld 408576698