Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 10763007: Add "regular_only" scope to allowed scopes for ChromeSetting.clear(). (Closed)

Created:
8 years, 5 months ago by Bernhard Bauer
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Add "regular_only" scope to allowed scopes for ChromeSetting.clear(). BUG=136387, 98431 TEST=see bug for manual test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/common/extensions/api/types.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/apps/types.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/extensions/types.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Please review. Thanks!
8 years, 5 months ago (2012-07-09 19:42:07 UTC) #1
Mihai Parparita -not on Chrome
LGTM
8 years, 5 months ago (2012-07-11 01:02:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10763007/1
8 years, 5 months ago (2012-07-11 08:30:27 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 09:49:47 UTC) #4
Change committed as 146093

Powered by Google App Engine
This is Rietveld 408576698