Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 10762017: PPAPI: Add an API for setting a custom user agent for URL requests. (Closed)

Created:
8 years, 5 months ago by viettrungluu
Modified:
8 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

PPAPI: Add an API for setting a custom user agent for URL requests. This doesn't hook it up yet. Pepper Flash needs this for RTMPT. BUG=134615 TEST=not really (except for trivial URL request test) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145885

Patch Set 1 #

Total comments: 3

Patch Set 2 : foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -11 lines) Patch
M ppapi/api/ppb_url_request_info.idl View 1 1 chunk +13 lines, -1 line 0 comments Download
M ppapi/c/ppb_url_request_info.h View 1 2 chunks +13 lines, -2 lines 0 comments Download
M ppapi/cpp/url_request_info.h View 2 chunks +19 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_url_request_info_shared.h View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppb_url_request_info_shared.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M ppapi/tests/test_url_request.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_request_info_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
8 years, 5 months ago (2012-07-10 01:09:38 UTC) #1
brettw
https://chromiumcodereview.appspot.com/10762017/diff/1/ppapi/api/ppb_url_request_info.idl File ppapi/api/ppb_url_request_info.idl (right): https://chromiumcodereview.appspot.com/10762017/diff/1/ppapi/api/ppb_url_request_info.idl#newcode152 ppapi/api/ppb_url_request_info.idl:152: * to set a custom content transfer encoding; if ...
8 years, 5 months ago (2012-07-10 04:54:45 UTC) #2
viettrungluu
https://chromiumcodereview.appspot.com/10762017/diff/1/ppapi/shared_impl/ppb_url_request_info_shared.h File ppapi/shared_impl/ppb_url_request_info_shared.h (right): https://chromiumcodereview.appspot.com/10762017/diff/1/ppapi/shared_impl/ppb_url_request_info_shared.h#newcode79 ppapi/shared_impl/ppb_url_request_info_shared.h:79: bool has_custom_user_agent; On 2012/07/10 04:54:45, brettw wrote: > Are ...
8 years, 5 months ago (2012-07-10 13:30:52 UTC) #3
brettw
8 years, 5 months ago (2012-07-10 14:06:34 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698