Chromium side of plumbing for passing renderer-generated keys through IPC

Chromium side of plumbing for passing renderer-generated keys through IPC
BUG=129471
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145998

[alecflett, 2012-07-10 00:13:08]

This needs to land first, so I can land putWithIndexKeys() on the webkit side,
and then I can call it again from over here. (see the TODO)

[jsbell, 2012-07-10 17:46:54]

+michaeln@

Overall lgtm with nits.

We discussed offline some issues with this direction - namely, if there's an
index delete/create that produces an index with the same name the wrong keypath
will have been used for the pre-calculated key. That may require plumbing
through the index id instead of names. 

This change is exploratory, though, and just used for assertions.

http://codereview.chromium.org/10759012/diff/1/content/browser/in_process_web...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/10759012/diff/1/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:714: //
TODO(alecflett): switch to putWithIndexKeys when available
Capitalize/add period.

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
File content/common/indexed_db/indexed_db_dispatcher.h (right):

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
content/common/indexed_db/indexed_db_dispatcher.h:180: const
WebKit::WebVector<WebKit::WebVector<WebKit::WebIDBKey> >& indexKeys,
This is a mouthful. Perhaps a typedef for the vector-of-names and
vector-of-vector-of-keys?

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
File content/common/indexed_db/indexed_db_messages.h (right):

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
content/common/indexed_db/indexed_db_messages.h:113: // the names of the indexes
used below
Capitalize/period.

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
content/common/indexed_db/indexed_db_messages.h:115: // the keys for each index
Capitalize/period. Also may want to clarify that the outer vector is per-index,
the inner vector is the list of keys for that index.

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/prox...
File content/common/indexed_db/proxy_webidbobjectstore_impl.cc (right):

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/prox...
content/common/indexed_db/proxy_webidbobjectstore_impl.cc:74:
SerializedScriptValue(value), content::IndexedDBKey(key),
Add a using content::IndexedDBKey; declaration near the top of the file and drop
the content:: namespace prefix here. (This entire file will move into the
content namespace eventually)

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/prox...
content/common/indexed_db/proxy_webidbobjectstore_impl.cc:91:
SerializedScriptValue(value), content::IndexedDBKey(key),
and here

[alecflett, 2012-07-10 21:19:06]

http://codereview.chromium.org/10759012/diff/1/content/browser/in_process_web...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/10759012/diff/1/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:714: //
TODO(alecflett): switch to putWithIndexKeys when available
On 2012/07/10 17:46:54, jsbell wrote:
> Capitalize/add period.

Done.

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
File content/common/indexed_db/indexed_db_dispatcher.h (right):

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
content/common/indexed_db/indexed_db_dispatcher.h:180: const
WebKit::WebVector<WebKit::WebVector<WebKit::WebIDBKey> >& indexKeys,
On 2012/07/10 17:46:54, jsbell wrote:
> This is a mouthful. Perhaps a typedef for the vector-of-names and
> vector-of-vector-of-keys?

I had that but...the typedefs ultimately need to be in the WebKit/chromium side
of things, so for now I'm landing this, I'll include the typedefs in my next
webkit landing, then adjust these in my next chromium landing (when I address
the TODO above)

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
File content/common/indexed_db/indexed_db_messages.h (right):

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
content/common/indexed_db/indexed_db_messages.h:113: // the names of the indexes
used below
On 2012/07/10 17:46:54, jsbell wrote:
> Capitalize/period.

Done.

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/inde...
content/common/indexed_db/indexed_db_messages.h:115: // the keys for each index
On 2012/07/10 17:46:54, jsbell wrote:
> Capitalize/period. Also may want to clarify that the outer vector is
per-index,
> the inner vector is the list of keys for that index.

Done.

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/prox...
File content/common/indexed_db/proxy_webidbobjectstore_impl.cc (right):

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/prox...
content/common/indexed_db/proxy_webidbobjectstore_impl.cc:74:
SerializedScriptValue(value), content::IndexedDBKey(key),
On 2012/07/10 17:46:54, jsbell wrote:
> Add a using content::IndexedDBKey; declaration near the top of the file and
drop
> the content:: namespace prefix here. (This entire file will move into the
> content namespace eventually)

Done.

http://codereview.chromium.org/10759012/diff/1/content/common/indexed_db/prox...
content/common/indexed_db/proxy_webidbobjectstore_impl.cc:91:
SerializedScriptValue(value), content::IndexedDBKey(key),
On 2012/07/10 17:46:54, jsbell wrote:
> and here

Done.

[commit-bot: I haz the power, 2012-07-10 21:22:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/10759012/7001

[commit-bot: I haz the power, 2012-07-10 21:42:25]

Try job failure for 10759012-7001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-10 22:23:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/10759012/2002

[commit-bot: I haz the power, 2012-07-11 00:03:17]

Change committed as 145998