Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 10759006: Simple event tests for the Bluetooth API. (Closed)

Created:
8 years, 5 months ago by bryeung
Modified:
8 years, 5 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Simple event tests for the Bluetooth API. TEST=added BUG=132616 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146193

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest_chromeos.cc View 1 3 chunks +24 lines, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/bluetooth/manifest.json View 1 chunk +7 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/bluetooth/test_events.html View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/bluetooth/test_events.js View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bryeung
Mike: I based this off the serial API tests. Can you review this?
8 years, 5 months ago (2012-07-09 20:57:14 UTC) #1
bryeung
friendly ping On 2012/07/09 20:57:14, bryeung wrote: > Mike: I based this off the serial ...
8 years, 5 months ago (2012-07-11 14:25:40 UTC) #2
miket_OOO
On 2012/07/11 14:25:40, bryeung wrote: > friendly ping > > On 2012/07/09 20:57:14, bryeung wrote: ...
8 years, 5 months ago (2012-07-11 16:28:28 UTC) #3
miket_OOO
LGTM (and I now see that I can edit the reviewers line myself, so I ...
8 years, 5 months ago (2012-07-11 16:32:53 UTC) #4
bryeung
http://codereview.chromium.org/10759006/diff/1/chrome/test/data/extensions/api_test/bluetooth/test_events.js File chrome/test/data/extensions/api_test/bluetooth/test_events.js (right): http://codereview.chromium.org/10759006/diff/1/chrome/test/data/extensions/api_test/bluetooth/test_events.js#newcode11 chrome/test/data/extensions/api_test/bluetooth/test_events.js:11: } On 2012/07/11 16:32:53, miket wrote: > This is ...
8 years, 5 months ago (2012-07-11 19:06:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/10759006/5002
8 years, 5 months ago (2012-07-11 19:07:56 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 20:35:14 UTC) #7
Change committed as 146193

Powered by Google App Engine
This is Rietveld 408576698