Add updateMenu for modifying the WiFi menu while it is open.

Add updateMenu for modifying the WiFi menu while it is open.

BUG=135092
TEST=Manually.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145875

[kevers, 2012-07-09 18:49:47]

Hi Chris,

Can you please have a look at this CL.

[csilv, 2012-07-09 19:13:14]

lgtm

http://codereview.chromium.org/10757004/diff/2001/chrome/browser/resources/op...
File chrome/browser/resources/options2/chromeos/network_list.js (right):

http://codereview.chromium.org/10757004/diff/2001/chrome/browser/resources/op...
chrome/browser/resources/options2/chromeos/network_list.js:596: * @return
{boolean}  True if successfully updated. A menu that cannot be
nit: single space before 'True'

http://codereview.chromium.org/10757004/diff/2001/chrome/browser/resources/op...
chrome/browser/resources/options2/chromeos/network_list.js:597: *     updated is
replaced with a new menu.
nit: I would recommend changing the @return description so that it doesn't imply
that it replaces the new menu here:
  "A menu that cannot be updated should be replaced with a new menu."

Alternatively, just remove the second sentence.

http://codereview.chromium.org/10757004/diff/2001/chrome/browser/resources/op...
chrome/browser/resources/options2/chromeos/network_list.js:639: */
nit: @private

[kevers, 2012-07-10 12:39:36]

http://codereview.chromium.org/10757004/diff/2001/chrome/browser/resources/op...
File chrome/browser/resources/options2/chromeos/network_list.js (right):

http://codereview.chromium.org/10757004/diff/2001/chrome/browser/resources/op...
chrome/browser/resources/options2/chromeos/network_list.js:596: * @return
{boolean}  True if successfully updated. A menu that cannot be
On 2012/07/09 19:13:14, csilv wrote:
> nit: single space before 'True'

Done.

http://codereview.chromium.org/10757004/diff/2001/chrome/browser/resources/op...
chrome/browser/resources/options2/chromeos/network_list.js:597: *     updated is
replaced with a new menu.
On 2012/07/09 19:13:14, csilv wrote:
> nit: I would recommend changing the @return description so that it doesn't
imply
> that it replaces the new menu here:
>   "A menu that cannot be updated should be replaced with a new menu."
> 
> Alternatively, just remove the second sentence.

Dropped the second sentence.

http://codereview.chromium.org/10757004/diff/2001/chrome/browser/resources/op...
chrome/browser/resources/options2/chromeos/network_list.js:639: */
On 2012/07/09 19:13:14, csilv wrote:
> nit: @private

Done.

[commit-bot: I haz the power, 2012-07-10 12:41:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/10757004/6001

[commit-bot: I haz the power, 2012-07-10 14:08:58]

Change committed as 145875