Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3687)

Unified Diff: chrome/browser/first_run/first_run.cc

Issue 10756023: Fix the first_run regression issue related to skip_first_run_ui setting processing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change back to SkipFirstRunUI. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/first_run/first_run.cc
diff --git a/chrome/browser/first_run/first_run.cc b/chrome/browser/first_run/first_run.cc
index dd04fde3476550f7dd8851b618c0583216609974..08d446960a041767a9db56ef0dfb69d8dfbe3949 100644
--- a/chrome/browser/first_run/first_run.cc
+++ b/chrome/browser/first_run/first_run.cc
@@ -267,14 +267,10 @@ void SetShowWelcomePagePrefIfNeeded(
}
bool SkipFirstRunUI(installer::MasterPreferences* install_prefs) {
- // TODO(mirandac): Refactor skip-first-run-ui process into regular first run
- // import process. http://crbug.com/49647
- // Note we are skipping all other master preferences if skip-first-run-ui
- // is *not* specified. (That is, we continue only if skipping first run ui.)
bool value = false;
- return (install_prefs->GetBool(
- installer::master_preferences::kDistroSkipFirstRunPref,
- &value) || !value);
+ install_prefs->GetBool(installer::master_preferences::kDistroSkipFirstRunPref,
+ &value);
+ return value;
}
void SetRLZPref(first_run::MasterPrefs* out_prefs,
« no previous file with comments | « no previous file | chrome/browser/first_run/first_run_internal.h » ('j') | chrome/browser/first_run/first_run_posix.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698