Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/browser/first_run/first_run_internal.h

Issue 10756023: Fix the first_run regression issue related to skip_first_run_ui setting processing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change back to SkipFirstRunUI. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_INTERNAL_H_ 5 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_INTERNAL_H_
6 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_INTERNAL_H_ 6 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_INTERNAL_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 // Sets up master preferences by preferences passed by installer. 56 // Sets up master preferences by preferences passed by installer.
57 void SetupMasterPrefsFromInstallPrefs( 57 void SetupMasterPrefsFromInstallPrefs(
58 MasterPrefs* out_prefs, 58 MasterPrefs* out_prefs,
59 installer::MasterPreferences* install_prefs); 59 installer::MasterPreferences* install_prefs);
60 60
61 void SetShowWelcomePagePrefIfNeeded( 61 void SetShowWelcomePagePrefIfNeeded(
62 installer::MasterPreferences* install_prefs); 62 installer::MasterPreferences* install_prefs);
63 63
64 void SetDefaultBrowser(installer::MasterPreferences* install_prefs); 64 void SetDefaultBrowser(installer::MasterPreferences* install_prefs);
65 65
66 // Returns true if the first-run-ui process should be skipped. 66 // Returns true if first run ui should be skipped, which is the case that
67 // skip_first_run_ui setting is set to true. In the case the setting is
68 // not found or specified, it returns false by default.
67 bool SkipFirstRunUI(installer::MasterPreferences* install_prefs); 69 bool SkipFirstRunUI(installer::MasterPreferences* install_prefs);
68 70
69 // Sets ping_delay. 71 // Sets ping_delay.
70 void SetRLZPref(first_run::MasterPrefs* out_prefs, 72 void SetRLZPref(first_run::MasterPrefs* out_prefs,
71 installer::MasterPreferences* install_prefs); 73 installer::MasterPreferences* install_prefs);
72 74
73 // -- Platform-specific functions -- 75 // -- Platform-specific functions --
74 76
75 // Gives the full path to the sentinel file. The file might not exist. 77 // Gives the full path to the sentinel file. The file might not exist.
76 // This function has a common implementation on OS_POSIX and a windows specific 78 // This function has a common implementation on OS_POSIX and a windows specific
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 const CommandLine& cmdline); 113 const CommandLine& cmdline);
112 114
113 #if !defined(OS_WIN) 115 #if !defined(OS_WIN)
114 bool ImportBookmarks(const FilePath& import_bookmarks_path); 116 bool ImportBookmarks(const FilePath& import_bookmarks_path);
115 #endif 117 #endif
116 118
117 } // namespace internal 119 } // namespace internal
118 } // namespace first_run 120 } // namespace first_run
119 121
120 #endif // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_INTERNAL_H_ 122 #endif // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_INTERNAL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698