Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5125)

Unified Diff: chrome/browser/extensions/script_badge_controller.cc

Issue 10754004: Remove the refcount from ScriptBadgeController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert ScopedObserver Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/script_badge_controller.cc
diff --git a/chrome/browser/extensions/script_badge_controller.cc b/chrome/browser/extensions/script_badge_controller.cc
index a45d026c40821a5e51f9685a838eab440109ec8f..d1d5e96ce57eaa417610030b10f585ca3ded88e9 100644
--- a/chrome/browser/extensions/script_badge_controller.cc
+++ b/chrome/browser/extensions/script_badge_controller.cc
@@ -23,9 +23,10 @@
namespace extensions {
-ScriptBadgeController::ScriptBadgeController(TabContents* tab_contents)
- : content::WebContentsObserver(tab_contents->web_contents()),
- script_executor_(tab_contents->web_contents()),
+ScriptBadgeController::ScriptBadgeController(TabContents* tab_contents,
+ ScriptExecutor* script_executor)
+ : ScriptExecutor::Observer(script_executor),
+ content::WebContentsObserver(tab_contents->web_contents()),
tab_contents_(tab_contents) {
registrar_.Add(this,
chrome::NOTIFICATION_EXTENSION_UNLOADED,
@@ -69,32 +70,8 @@ LocationBarController::Action ScriptBadgeController::OnClicked(
return ACTION_NONE;
}
-void ScriptBadgeController::ExecuteScript(
- const std::string& extension_id,
- ScriptExecutor::ScriptType script_type,
- const std::string& code,
- ScriptExecutor::FrameScope frame_scope,
- UserScript::RunLocation run_at,
- ScriptExecutor::WorldType world_type,
- const ExecuteScriptCallback& callback) {
- ExecuteScriptCallback this_callback = base::Bind(
- &ScriptBadgeController::OnExecuteScriptFinished,
- this,
- extension_id,
- callback);
-
- script_executor_.ExecuteScript(extension_id,
- script_type,
- code,
- frame_scope,
- run_at,
- world_type,
- this_callback);
-}
-
void ScriptBadgeController::OnExecuteScriptFinished(
const std::string& extension_id,
- const ExecuteScriptCallback& callback,
bool success,
int32 page_id,
const std::string& error) {
@@ -102,8 +79,6 @@ void ScriptBadgeController::OnExecuteScriptFinished(
if (InsertExtension(extension_id))
NotifyChange();
}
-
- callback.Run(success, page_id, error);
}
ExtensionService* ScriptBadgeController::GetExtensionService() {
« no previous file with comments | « chrome/browser/extensions/script_badge_controller.h ('k') | chrome/browser/extensions/script_badge_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698