Enable compilation of more files in base/ on iOS.

Enable compilation of more files in base/ on iOS.

TBR=
BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146060

[rohitrao (ping after 24h), 2012-07-09 17:04:16]

These files all seemed to compile ok locally, and I didn't see any diffs in our
tree.  Am I missing something?

[stuartmorgan, 2012-07-09 21:16:42]

LGTM if they compile; I was doing a bunch of hacking and slashing when I did
that first base CL so it wouldn't surprise me if I took too much out.

[stuartmorgan, 2012-07-10 08:03:48]

On 2012/07/09 21:16:42, stuartmorgan wrote:
> LGTM if they compile

Which they don't for device. I recommend doing device builds as we upstream to
prevent us upstreaming things that only work because of header bleed in the
simulator.

If you base/float_util.h with this you can do json and values. high_res_timer
needs system_monitor.h

[rohitrao (ping after 24h), 2012-07-10 11:40:23]

Good catch!  I'll sit on this until those other two CLs are in, then we can come
back to this one.

[stuartmorgan, 2012-07-10 11:52:54]

On 2012/07/10 11:40:23, rohitrao wrote:
> Good catch!  I'll sit on this until those other two CLs are in, then we can
come
> back to this one.

I'd say pull high_res_timer out of this CL, and then it can go it as soon as my
in-flight CL lands. Not sure when exactly we'll do system_monitor.

[stuartmorgan, 2012-07-10 11:53:28]

On 2012/07/10 11:52:54, stuartmorgan wrote:
> Not sure when exactly we'll do system_monitor.

Unless you're doing it now. Ignore me :)

[rohitrao (ping after 24h), 2012-07-10 19:36:37]

Ok, these all compile in device builds now.

Mark, do you want to review ios-only gyp changes, or is the sort of thing I
should TBR=mark?  Not sure what the rules are for OWNERS and trivial gyp
changes.

[Mark Mentovai, 2012-07-10 19:53:02]

I don’t want to review any .gyp changes as boring as this one.

[Mark Mentovai, 2012-07-10 19:53:31]

Just write TBR= when this happens.

Empty. That’s right.

[commit-bot: I haz the power, 2012-07-10 19:54:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10754002/8001

[rohitrao (ping after 24h), 2012-07-10 19:56:49]

Well that was unexpected. 

Thanks for not reviewing!

[Mark Mentovai, 2012-07-10 20:02:25]

Sorry. Nothing personal. LGTM on this one. I just get a lot of garbage reviews
that I don’t really need to look at at all because people are looking blindly at
OWNERS and playing by the rules without exercising judgement. As long as
someone’s reviewed a trivial gyp change like this (and Stuart has), it’s fine by
me.

[commit-bot: I haz the power, 2012-07-10 21:25:40]

Try job failure for 10754002-8001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-07-11 04:11:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10754002/8001

[commit-bot: I haz the power, 2012-07-11 05:37:58]

Change committed as 146060