Issue 10753023: Disable the spellcheck service when asynchronous spellchecking is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10753023: Disable the spellcheck service when asynchronous spellchecking is disabled. (Closed)

Created:
8 years, 5 months ago by Hironori Bono

Modified:
8 years, 5 months ago

Reviewers:
Hajime Morrita

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disable the spellcheck service when asynchronous spellchecking is disabled. This change prevents using the spellcheck service when Chrome is launched with a --disable-asynchronous-spellchecking flag because the spellcheck service depends on asynchronous spellchecking. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146070

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/spellchecker/spelling_service_client.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Good catch!

Expand Messages | Collapse Messages