In Windows 8 chrome metro mode if we Alt tabbed away from chrome while a tab was loading, we would …

In Windows 8 chrome metro mode if we Alt tabbed away from chrome while a tab was loading, we would end up 
with a desktop mode render widget view window. The RenderWidgetHostViewWin instance is created with a valid
parent window which is the web contents window. We hide it initially and make it visible when the navigation
is completed. In the code for hiding the view we call setparent with NULL to orphan the window and then reparent
it to the original parent when the view is made visible.

This parenting/reparenting code confuses windows 8 metro when we switch focus away to the desktop after the window
is hidden and before it becomes visible.

In any case we won't receive any paint messages after a window is hidden which is already occurring here.

Removing the code to unparent and reparent the RenderWidgetHostViewWin instance.

BUG=136272
R=cpu
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145957

[cpu_(ooo_6.6-7.5), 2012-07-10 02:45:17]

you probably want to add an owner of content to the review :)

https://chromiumcodereview.appspot.com/10753017/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_win.cc (left):

https://chromiumcodereview.appspot.com/10753017/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_view_win.cc:968: }
do we need the parent_hwnd_ anymore?

[ivan_cobs.com.sg, 2012-07-10 03:46:29]

Pls remove the following email adds from your list NOW

ivan@cobs.com.sg
lynn@cobs.com.sg

-----Original Message-----
From: cpu@chromium.org [mailto:cpu@chromium.org] 
Sent: Tuesday, 10 July, 2012 10:45 AM
To: ananta@chromium.org
Cc: chromium-reviews@chromium.org; yusukes+watch@chromium.org;
jam@chromium.org; penghuang+watch@chromium.org;
joi+watch-content@chromium.org; darin-cc@chromium.org; suzhe@chromium.org
Subject: [chromium-reviews] Re: In Windows 8 chrome metro mode if we Alt
tabbed away from chrome while a tab was loading, we would . (issue 10753017)

you probably want to add an owner of content to the review :)


https://chromiumcodereview.appspot.com/10753017/diff/1/content/browser/rende
rer_host/render_widget_host_view_win.cc
File content/browser/renderer_host/render_widget_host_view_win.cc
(left):

https://chromiumcodereview.appspot.com/10753017/diff/1/content/browser/rende
rer_host/render_widget_host_view_win.cc#oldcode968
content/browser/renderer_host/render_widget_host_view_win.cc:968: } do we
need the parent_hwnd_ anymore?

https://chromiumcodereview.appspot.com/10753017/

[ananta, 2012-07-10 17:58:26]

On 2012/07/10 17:57:18, ananta wrote:

Removed the parent_hwnd_ member.

[Ben Goodger (Google), 2012-07-10 18:00:01]

Cool lgtm.