Issue 10753007: Switch base/ registrations to a static class method where appropriate.

Issue 10753007: Switch base/ registrations to a static class method where appropriate. (Closed)

Created:
8 years, 5 months ago by nilesh

Modified:
8 years, 5 months ago

Reviewers:
Mark Mentovai, Yaron

CC:
chromium-reviews, erikwright (departed), sadrul, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch base/ registrations to a static class method where appropriate. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145757

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
M	base/android/base_jni_registrar.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download
M	base/android/build_info.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/android/build_info.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	base/message_pump_android.h	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	base/message_pump_android.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM otherwise for base OWNERS approval. Please also wait for Yaron’s review. http://codereview.chromium.org/10753007/diff/1/base/android/build_info.h File base/android/build_info.h ...

8 years, 5 months ago (2012-07-09 20:35:24 UTC) #2

nilesh

Thanks. http://codereview.chromium.org/10753007/diff/1/base/android/build_info.h File base/android/build_info.h (right): http://codereview.chromium.org/10753007/diff/1/base/android/build_info.h#newcode72 base/android/build_info.h:72: On 2012/07/09 20:35:24, Mark Mentovai wrote: > Extra ...

8 years, 5 months ago (2012-07-09 20:46:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10753007/8001

8 years, 5 months ago (2012-07-09 20:55:54 UTC) #5

Change committed as 145757

Expand Messages | Collapse Messages