Add jln@ as OWNER of sandboxing and Zygote

Add Julien Tinnes as OWNER of Linux sandboxing and Zygote
Add Chris Evans as OWNER of sandbox/
Set noparent in sandbox/

BUG=
TEST=
NOTRY=true


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145756

[jln (very slow on Chromium), 2012-07-09 17:46:05]

This is to add myself as OWNER

Justin: for sandbox/
Markus: for content/zygote
Brett / Chris: for content/common

[cevans, 2012-07-09 18:01:48]

I'd like to see you create sandbox/linux/OWNERS and:
- Put yourself in there.
- Also add "set noparent"; this will help prevent crazy stuff getting added
to the suid sandbox and upsetting you :-)
- Feel free to put me in there (as well as Markus of couse) so that we have
a decent number of reviewers for a "noparent" directory.

On Mon, Jul 9, 2012 at 10:46 AM, <jln@chromium.org> wrote:

> Reviewers: Markus (顧孟勤), jschuh, cevans, brettw,
>
> Message:
> This is to add myself as OWNER
>
> Justin: for sandbox/
> Markus: for content/zygote
> Brett / Chris: for content/common
>
> Description:
> Add Julien Tinnes as OWNER of sandboxing and Zygote
>
>
> BUG=
> TEST=
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10753003/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M content/common/OWNERS
>   M content/zygote/OWNERS
>   M sandbox/OWNERS
>
>
> Index: content/common/OWNERS
> diff --git a/content/common/OWNERS b/content/common/OWNERS
> index fcce972ffd89e99c560efe95e1983b**85a9f97311..**
> f8fc447863f72f8b17a660f7da1cf6**f95a25ec87 100644
> --- a/content/common/OWNERS
> +++ b/content/common/OWNERS
> @@ -1,5 +1,6 @@
>  # For sandbox_init_linux.cc
>  cevans@chromium.org
> +jln@chromium.org
>
>  # For sandbox_policy.cc
>  jschuh@chromium.org
> Index: content/zygote/OWNERS
> diff --git a/content/zygote/OWNERS b/content/zygote/OWNERS
> index 1432c994b42b7bcaed03e83ea690f0**ddb404d3d0..**
> 602e00e0750432a8d89286edcfd6a8**f16fbd6b3d 100644
> --- a/content/zygote/OWNERS
> +++ b/content/zygote/OWNERS
> @@ -1,4 +1,3 @@
>  markus@chromium.org
>  cevans@chromium.org
> -# jln@chromium.org should be added as soon as he is committer. Ping
> -# cevans when we are ready for that
> +jln@chromium.org
> Index: sandbox/OWNERS
> diff --git a/sandbox/OWNERS b/sandbox/OWNERS
> index 4eeecc186158343a87715924418cfb**342b3fd243..**
> 44c6e36b78b1898cec34ea79bfd9eb**ba6d67d33c 100644
> --- a/sandbox/OWNERS
> +++ b/sandbox/OWNERS
> @@ -2,4 +2,6 @@ cpu@chromium.org
>  jschuh@chromium.org
>  nsylvain@chromium.org
>  rvargas@chromium.org
> +# For Linux:
>  markus@chromium.org
> +jln@chromium.org
>
>
>

[jln (very slow on Chromium), 2012-07-09 18:06:41]

But we also need control over the new sandbox_linux.gypi I created. Moving it to
linux/ is not completely trivial and it would accentuate the lack of symmetry
between Windows (which is in /) and Linux (which is in linux/).

Could we maybe set noparent in sandbox/ instead? Justin, what do you think ?

> I'd like to see you create sandbox/linux/OWNERS and:
> - Put yourself in there.
> - Also add "set noparent"; this will help prevent crazy stuff getting added
> to the suid sandbox and upsetting you :-)
> - Feel free to put me in there (as well as Markus of couse) so that we have
> a decent number of reviewers for a "noparent" directory.
> 
> On Mon, Jul 9, 2012 at 10:46 AM, <mailto:jln@chromium.org> wrote:
> 
> > Reviewers: Markus (顧孟勤), jschuh, cevans, brettw,
> >
> > Message:
> > This is to add myself as OWNER
> >
> > Justin: for sandbox/
> > Markus: for content/zygote
> > Brett / Chris: for content/common
> >
> > Description:
> > Add Julien Tinnes as OWNER of sandboxing and Zygote
> >
> >
> > BUG=
> > TEST=
> >
> >
> > Please review this at
>
https://chromiumcodereview.**appspot.com/10753003/%3Chttps://chromiumcoderevi...>
> >
> > SVN Base:
>
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
> >
> > Affected files:
> >   M content/common/OWNERS
> >   M content/zygote/OWNERS
> >   M sandbox/OWNERS
> >
> >
> > Index: content/common/OWNERS
> > diff --git a/content/common/OWNERS b/content/common/OWNERS
> > index fcce972ffd89e99c560efe95e1983b**85a9f97311..**
> > f8fc447863f72f8b17a660f7da1cf6**f95a25ec87 100644
> > --- a/content/common/OWNERS
> > +++ b/content/common/OWNERS
> > @@ -1,5 +1,6 @@
> >  # For sandbox_init_linux.cc
> >  mailto:cevans@chromium.org
> > mailto:+jln@chromium.org
> >
> >  # For sandbox_policy.cc
> >  mailto:jschuh@chromium.org
> > Index: content/zygote/OWNERS
> > diff --git a/content/zygote/OWNERS b/content/zygote/OWNERS
> > index 1432c994b42b7bcaed03e83ea690f0**ddb404d3d0..**
> > 602e00e0750432a8d89286edcfd6a8**f16fbd6b3d 100644
> > --- a/content/zygote/OWNERS
> > +++ b/content/zygote/OWNERS
> > @@ -1,4 +1,3 @@
> >  mailto:markus@chromium.org
> >  mailto:cevans@chromium.org
> > -# mailto:jln@chromium.org should be added as soon as he is committer. Ping
> > -# cevans when we are ready for that
> > mailto:+jln@chromium.org
> > Index: sandbox/OWNERS
> > diff --git a/sandbox/OWNERS b/sandbox/OWNERS
> > index 4eeecc186158343a87715924418cfb**342b3fd243..**
> > 44c6e36b78b1898cec34ea79bfd9eb**ba6d67d33c 100644
> > --- a/sandbox/OWNERS
> > +++ b/sandbox/OWNERS
> > @@ -2,4 +2,6 @@ mailto:cpu@chromium.org
> >  mailto:jschuh@chromium.org
> >  mailto:nsylvain@chromium.org
> >  mailto:rvargas@chromium.org
> > +# For Linux:
> >  mailto:markus@chromium.org
> > mailto:+jln@chromium.org
> >
> >
> >

[jam, 2012-07-09 18:06:42]

On 2012/07/09 18:01:48, cevans wrote:
> I'd like to see you create sandbox/linux/OWNERS and:
> - Put yourself in there.
> - Also add "set noparent"; this will help prevent crazy stuff getting added
> to the suid sandbox and upsetting you :-)

Per Ben's email to chromium-dev, we don't want to add "set noparent" anywhere.
see the thread for more info.

> - Feel free to put me in there (as well as Markus of couse) so that we have
> a decent number of reviewers for a "noparent" directory.
>

[cevans, 2012-07-09 18:21:17]

On Mon, Jul 9, 2012 at 11:06 AM, <jam@chromium.org> wrote:

> On 2012/07/09 18:01:48, cevans wrote:
>
>> I'd like to see you create sandbox/linux/OWNERS and:
>> - Put yourself in there.
>> - Also add "set noparent"; this will help prevent crazy stuff getting
>> added
>> to the suid sandbox and upsetting you :-)
>>
>
> Per Ben's email to chromium-dev, we don't want to add "set noparent"
> anywhere.
> see the thread for more info.


Chatted to John off-thread and for now, we should add "set noparent" to
sandbox/OWNERS. You can add me too if you want, so we have more qualified
people in case others are on vacation etc.

According to John:
---
probably wanna copy the comment from content/OWNERS
# The set noparent is temporary until src/OWNERS isn't *.
---

Cheers
Chris


>
>  - Feel free to put me in there (as well as Markus of couse) so that we
>> have
>> a decent number of reviewers for a "noparent" directory.
>>
>
>
>
https://chromiumcodereview.**appspot.com/10753003/<https://chromiumcodereview...
>

[jln (very slow on Chromium), 2012-07-09 18:35:32]

On 2012/07/09 18:21:17, cevans wrote:
> Chatted to John off-thread and for now, we should add "set noparent" to
> sandbox/OWNERS. You can add me too if you want, so we have more qualified
> people in case others are on vacation etc.

I think Justin told me before we weren't ready for noparent on sandbox/. Justin
?

Also if the noparent part starts being controversial / complex, I would advocate
having that discussion in another CL.

[jschuh, 2012-07-09 20:22:02]

On 2012/07/09 18:35:32, Julien Tinnes wrote:
> On 2012/07/09 18:21:17, cevans wrote:
> > Chatted to John off-thread and for now, we should add "set noparent" to
> > sandbox/OWNERS. You can add me too if you want, so we have more qualified
> > people in case others are on vacation etc.
> 
> I think Justin told me before we weren't ready for noparent on sandbox/.
Justin
> ?

I just didn't want noparent until we had enough people to service reviews. Looks
like we do now so lets do it.

> 
> Also if the noparent part starts being controversial / complex, I would
advocate
> having that discussion in another CL.

[jln (very slow on Chromium), 2012-07-09 20:27:02]

Alright, PTAL!

[jschuh, 2012-07-09 20:29:52]

lgtm

[Chris Evans, 2012-07-09 20:31:35]

On 2012/07/09 20:29:52, Justin Schuh wrote:
> lgtm

LGTM

[jln (very slow on Chromium), 2012-07-09 20:43:00]

John, since you've already discussed this with Chris, do you mind approving for
content/common instead of Brett ?

[Markus (顧孟勤), 2012-07-09 20:47:19]

lgtm

[jam, 2012-07-09 21:03:53]

lgtm

[commit-bot: I haz the power, 2012-07-09 22:11:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10753003/6001

[commit-bot: I haz the power, 2012-07-09 22:11:15]

Change committed as 145756