Issue 10752020: [MIPS] Set endianness for MIPS architecture in http_auth_handler_ntlm_portable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10752020: [MIPS] Set endianness for MIPS architecture in http_auth_handler_ntlm_portable. (Closed)

Created:
8 years, 5 months ago by petarj

Modified:
8 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[MIPS] Set endianness for MIPS architecture in http_auth_handler_ntlm_portable. Small patch to set correctly endianness for MIPS arch. BUG=https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145928

Patch Set 1 #

Total comments: 1

Patch Set 2 : Wrap a long line. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	net/http/http_auth_handler_ntlm_portable.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

Sorry for the delay. LGTM (modulo the nit) http://codereview.chromium.org/10752020/diff/1/net/http/http_auth_handler_ntlm_portable.cc File net/http/http_auth_handler_ntlm_portable.cc (right): http://codereview.chromium.org/10752020/diff/1/net/http/http_auth_handler_ntlm_portable.cc#newcode74 net/http/http_auth_handler_ntlm_portable.cc:74: #if ...

8 years, 5 months ago (2012-07-10 16:59:46 UTC) #2

petarj

I have just updated the patch with the long line wrapped in two.

8 years, 5 months ago (2012-07-10 17:38:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/10752020/5001

8 years, 5 months ago (2012-07-10 17:41:59 UTC) #5

Change committed as 145928

Expand Messages | Collapse Messages