Adding a field trial to enable speculative resource prefetching learning.

Adding a field trial to enable speculative resource prefetching learning.


BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146170

[Shishir, 2012-07-09 20:51:55]

Please take a look.

[dominich, 2012-07-09 20:57:23]

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/browser/prerend...
File chrome/browser/prerender/prerender_field_trial.cc (left):

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/browser/prerend...
chrome/browser/prerender/prerender_field_trial.cc:125: 
nit: remove blank line

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/browser/prerend...
File chrome/browser/prerender/prerender_field_trial.cc (right):

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/browser/prerend...
chrome/browser/prerender/prerender_field_trial.cc:28: int
g_speculative_prfetching_learning_default_group_number = -1;
typo: prefetching

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/common/chrome_s...
File chrome/common/chrome_switches.h (right):

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/common/chrome_s...
chrome/common/chrome_switches.h:319: extern const char
kSpeculativeResourcePrefetchingLearning[];
Why not 'Enabled'? Are you planning on multiple states?

[Shishir, 2012-07-09 21:01:57]

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/browser/prerend...
File chrome/browser/prerender/prerender_field_trial.cc (left):

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/browser/prerend...
chrome/browser/prerender/prerender_field_trial.cc:125: 
On 2012/07/09 20:57:23, dominich wrote:
> nit: remove blank line

Done.

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/browser/prerend...
File chrome/browser/prerender/prerender_field_trial.cc (right):

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/browser/prerend...
chrome/browser/prerender/prerender_field_trial.cc:28: int
g_speculative_prfetching_learning_default_group_number = -1;
On 2012/07/09 20:57:23, dominich wrote:
> typo: prefetching

Done.

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/common/chrome_s...
File chrome/common/chrome_switches.h (right):

https://chromiumcodereview.appspot.com/10752006/diff/1/chrome/common/chrome_s...
chrome/common/chrome_switches.h:319: extern const char
kSpeculativeResourcePrefetchingLearning[];
On 2012/07/09 20:57:23, dominich wrote:
> Why not 'Enabled'? Are you planning on multiple states?

I was thinking we would have three states - enabled, learning - where we learn
and measure accuracy but do not prefetch and enabled - where we actually
prefetch.

[dominich, 2012-07-09 21:06:23]

lgtm

[Shishir, 2012-07-09 21:12:54]

Adding thakis for:

chrome/app/generated_resources.grd
chrome/browser/about_flags.cc
chrome/common/chrome_switches.h
chrome/common/chrome_switches.cc

Please take a look.

[Shishir, 2012-07-10 21:10:30]

On 2012/07/09 21:12:54, Shishir wrote:
> Adding thakis for:
> 
> chrome/app/generated_resources.grd
> chrome/browser/about_flags.cc
> chrome/common/chrome_switches.h
> chrome/common/chrome_switches.cc
> 
> Please take a look.

Adding jam for the following:

chrome/app/generated_resources.grd
chrome/browser/about_flags.cc
chrome/common/chrome_switches.h
chrome/common/chrome_switches.cc

Please take a look.

[jam, 2012-07-10 23:53:20]

lgtm

[commit-bot: I haz the power, 2012-07-11 18:25:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shishir@chromium.org/10752006/14001

[commit-bot: I haz the power, 2012-07-11 19:28:50]

Change committed as 146170