Issue 10750018: Remove browser::FindLastActiveWithProfile call in importer code. There are many ways to create an I…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10750018: Remove browser::FindLastActiveWithProfile call in importer code. There are many ways to create an I… (Closed)

Created:
8 years, 5 months ago by jam

Modified:
8 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove browser::FindLastActiveWithProfile call in importer code. There are many ways to create an ImporterHost, but only when it's created from the webui do we give the option to import from Google Toolbar. In that case, pass the Browser* directly. BUG=129187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145890

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -6 lines)			Patch
M	chrome/browser/importer/importer_host.h	View	5 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/importer/importer_host.cc	View	5 chunks	+10 lines, -5 lines	1 comment	Download
M	chrome/browser/ui/webui/options2/import_data_handler2.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 5 months ago (2012-07-10 15:13:10 UTC) #2

lgtm

http://codereview.chromium.org/10750018/diff/1/chrome/browser/importer/import...
File chrome/browser/importer/importer_host.cc (right):

http://codereview.chromium.org/10750018/diff/1/chrome/browser/importer/import...
chrome/browser/importer/importer_host.cc:272: browser_ = NULL;
idle thinking... would be cool if this could somehow just be a page navigator,
but you have no way of invalidating it unless you're a browserlist observer, so
what you have is fine.

Expand Messages | Collapse Messages