Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10750016: Moved c/b/e/*idle* to c/b/e/api/idle/ (Closed)

Created:
8 years, 5 months ago by mitchellwrosen
Modified:
8 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : -> extensions namespace #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : Sync with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -561 lines) Patch
A + chrome/browser/extensions/api/idle/idle_api.h View 1 2 3 chunks +11 lines, -4 lines 0 comments Download
A + chrome/browser/extensions/api/idle/idle_api.cc View 1 2 4 chunks +10 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/api/idle/idle_api_constants.h View 1 2 chunks +9 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/api/idle/idle_api_constants.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/idle/idle_api_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A + chrome/browser/extensions/api/idle/idle_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
D chrome/browser/extensions/extension_idle_api.h View 1 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/extensions/extension_idle_api.cc View 1 2 1 chunk +0 lines, -272 lines 0 comments Download
D chrome/browser/extensions/extension_idle_api_constants.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/extensions/extension_idle_api_constants.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/extensions/extension_idle_api_unittest.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/extensions/extension_idle_apitest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 5 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
mitchellwrosen
8 years, 5 months ago (2012-07-10 00:03:17 UTC) #1
vabr (Chromium)
Hi Mitchell, As in Issue 10757014, I left a comment, but you have to find ...
8 years, 5 months ago (2012-07-10 07:32:55 UTC) #2
vabr (Chromium)
http://codereview.chromium.org/10750016/diff/1/chrome/browser/extensions/api/idle/idle_api.h File chrome/browser/extensions/api/idle/idle_api.h (right): http://codereview.chromium.org/10750016/diff/1/chrome/browser/extensions/api/idle/idle_api.h#newcode15 chrome/browser/extensions/api/idle/idle_api.h:15: class ExtensionIdleEventRouter { Consider moving the classes defined here ...
8 years, 5 months ago (2012-07-10 07:39:30 UTC) #3
mitchellwrosen
8 years, 5 months ago (2012-07-23 20:07:01 UTC) #4
mitchellwrosen
-bolms, +yoz
8 years, 4 months ago (2012-07-27 20:16:39 UTC) #5
Yoyo Zhou
LGTM http://chromiumcodereview.appspot.com/10750016/diff/7001/chrome/browser/extensions/api/idle/idle_api.cc File chrome/browser/extensions/api/idle/idle_api.cc (right): http://chromiumcodereview.appspot.com/10750016/diff/7001/chrome/browser/extensions/api/idle/idle_api.cc#newcode85 chrome/browser/extensions/api/idle/idle_api.cc:85: extensions::ExtensionIdleEventRouter::OnIdleStateChange(profile_, If you're using this class you shouldn't ...
8 years, 4 months ago (2012-07-30 08:16:27 UTC) #6
mitchellwrosen
+jhawkins for chrome/ http://chromiumcodereview.appspot.com/10750016/diff/7001/chrome/browser/extensions/api/idle/idle_api.cc File chrome/browser/extensions/api/idle/idle_api.cc (right): http://chromiumcodereview.appspot.com/10750016/diff/7001/chrome/browser/extensions/api/idle/idle_api.cc#newcode85 chrome/browser/extensions/api/idle/idle_api.cc:85: extensions::ExtensionIdleEventRouter::OnIdleStateChange(profile_, On 2012/07/30 08:16:27, Yoyo Zhou ...
8 years, 4 months ago (2012-07-30 17:29:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10750016/15001
8 years, 4 months ago (2012-07-30 21:49:03 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/browser/extensions/extension_function_registry.cc: While running patch -p1 --forward --force; patching file chrome/browser/extensions/extension_function_registry.cc ...
8 years, 4 months ago (2012-07-30 23:22:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10750016/20001
8 years, 4 months ago (2012-07-30 23:40:42 UTC) #10
commit-bot: I haz the power
Change committed as 149108
8 years, 4 months ago (2012-07-31 01:26:42 UTC) #11
James Hawkins
I'm not sure if you wanted my review, but I was never added to the ...
8 years, 4 months ago (2012-07-31 02:15:10 UTC) #12
mitchellwrosen
8 years, 4 months ago (2012-07-31 17:18:33 UTC) #13 
On 2012/07/31 02:15:10, James Hawkins wrote:
> I'm not sure if you wanted my review, but I was never added to the reviewer
list
> (even though you said +jhawkins).

Sorry about that, I was told by kalman in another CL that the correct way to get
a review for a chrome/ .gypi change is to just TBR an owner rather than get an
LGTM. I think I added you as a reviewer then removed you, or maybe I forgot to
add you in the first place. Apologies!

Powered by Google App Engine
This is Rietveld 408576698