Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 10750013: Fix typo in the new chrome histograms. (Closed)

Created:
8 years, 5 months ago by noelutz
Modified:
8 years, 5 months ago
Reviewers:
mattm
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes a typo for the new SafeBrowsing histograms. The cmd variable might contain quotes which makes the code in RecordUserReactionTime fail because strings don't match the expected commands. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
noelutz
8 years, 5 months ago (2012-07-09 23:11:46 UTC) #1
mattm
lgtm
8 years, 5 months ago (2012-07-09 23:13:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelutz@google.com/10750013/1
8 years, 5 months ago (2012-07-09 23:16:18 UTC) #3
commit-bot: I haz the power
Try job failure for 10750013-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-10 00:21:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelutz@google.com/10750013/1
8 years, 5 months ago (2012-07-10 00:42:31 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 02:05:41 UTC) #6
Change committed as 145823

Powered by Google App Engine
This is Rietveld 408576698