Issue 10750007: [depot_tools] Allow gclient runhooks to work offline w/safesync_url.

Issue 10750007: [depot_tools] Allow gclient runhooks to work offline w/safesync_url. (Closed)

Created:
8 years, 5 months ago by Dan Beam

Modified:
8 years, 5 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

[depot_tools] Allow gclient runhooks to work offline w/safesync_url. R=maruel@chromium.org BUG=None (AFAIK) TEST=Turn off networking, run gclient runhooks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145878

Patch Set 2 : pylint + removing revinfo #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	gclient.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/trychange_unittest.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

https://chromiumcodereview.appspot.com/10750007/diff/1/gclient.py File gclient.py (right): https://chromiumcodereview.appspot.com/10750007/diff/1/gclient.py#newcode1010 gclient.py:1010: if command not in ('diff', 'status', 'recurse', 'revinfo', 'runhooks'): ...

8 years, 5 months ago (2012-07-09 19:45:17 UTC) #2

Dan Beam

tried the other commands offline using git (and partially with svn, just ran svn diff ...

8 years, 5 months ago (2012-07-09 20:59:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/10750007/4001

8 years, 5 months ago (2012-07-10 14:47:34 UTC) #5

Change committed as 145878

Expand Messages | Collapse Messages