Issue 10750005: PPAPI/NaCl: Support Handle passing in ipc_channel_nacl

Issue 10750005: PPAPI/NaCl: Support Handle passing in ipc_channel_nacl (Closed)

Created:
8 years, 5 months ago by dmichael (off chromium)

Modified:
8 years, 5 months ago

Reviewers:
Mark Seaborn, brettw

CC:
chromium-reviews, darin-cc_chromium.org, jam, bbudge

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI/NaCl: Support Handle passing in ipc_channel_nacl This is speculative, since we don't have the underlying support in NaClIPCAdapter. But I verified locally that it works as well as it did before (i.e., sending data works). BUG=116317 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145899

Patch Set 1 : some pre-review cleanup #

Patch Set 2 : Add a DCHECK for number of FDs #

Total comments: 2

Patch Set 3 : Fixes based on review comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -33 lines)			Patch
	M	ipc/ipc_channel_nacl.h	View		3 chunks	+15 lines, -4 lines	0 comments	Download
	M	ipc/ipc_channel_nacl.cc	View	1 2	9 chunks	+61 lines, -29 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://chromiumcodereview.appspot.com/10750005/diff/9001/ipc/ipc_channel_nacl.cc File ipc/ipc_channel_nacl.cc (right): https://chromiumcodereview.appspot.com/10750005/diff/9001/ipc/ipc_channel_nacl.cc#newcode51 ipc/ipc_channel_nacl.cc:51: return false; I might feel a little better ...

8 years, 5 months ago (2012-07-10 05:04:07 UTC) #2

Mark Seaborn

Looks OK based on skimming https://chromiumcodereview.appspot.com/10750005/diff/9001/ipc/ipc_channel_nacl.cc File ipc/ipc_channel_nacl.cc (right): https://chromiumcodereview.appspot.com/10750005/diff/9001/ipc/ipc_channel_nacl.cc#newcode257 ipc/ipc_channel_nacl.cc:257: DCHECK(num_fds < FileDescriptorSet::kMaxDescriptorsPerMessage); Nit: ...

8 years, 5 months ago (2012-07-10 15:26:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/10750005/12001

8 years, 5 months ago (2012-07-10 16:01:12 UTC) #4

Change committed as 145899

Expand Messages | Collapse Messages