Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/library_dirs/subdir/mylib.h

Issue 10749020: Adds support for the library_dirs key, which appears in the documentation but was never actually im… (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: library_dirs Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/library_dirs/subdir/hello.cc ('K') | « test/library_dirs/subdir/hello.cc ('k') | test/library_dirs/subdir/mylib.cc » ('j') | test/library_dirs/subdir/test.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/library_dirs/subdir/mylib.h
===================================================================
--- test/library_dirs/subdir/mylib.h (revision 0)
+++ test/library_dirs/subdir/mylib.h (revision 0)
@@ -0,0 +1,12 @@
+// Copyright (c) 2012 Google Inc. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef _TEST_LIBRARY_DIRS_SUBDIR_MYLIB_H_
Mark Mentovai 2013/05/29 13:23:07 Your macros shouldn’t begin with an underscore, th
Dimi Shahbaz 2013/05/29 21:32:41 Done.
+#define _TEST_LIBRARY_DIRS_SUBDIR_MYLIB_H_
+
+#include <string>
+
+std::string my_foo(int);
+
+#endif // _TEST_LIBRARY_DIRS_SUBDIR_MYLIB_H_
Mark Mentovai 2013/05/29 13:23:07 Two spaces before the //. These are both covered
Dimi Shahbaz 2013/05/29 21:32:41 Done.
« test/library_dirs/subdir/hello.cc ('K') | « test/library_dirs/subdir/hello.cc ('k') | test/library_dirs/subdir/mylib.cc » ('j') | test/library_dirs/subdir/test.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698