Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: content/common/gpu/media/mac_video_decode_accelerator.h

Issue 10749019: VideoDecodeAccelerator now SupportsWeakPtr instead of being RefCountedThreadSafe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/mac_video_decode_accelerator.h
diff --git a/content/common/gpu/media/mac_video_decode_accelerator.h b/content/common/gpu/media/mac_video_decode_accelerator.h
index 55cb55bc250129ec8a64998360c60e994f968eca..2aa3830b5dcf9dd9e750d8ea36711b43866908ca 100644
--- a/content/common/gpu/media/mac_video_decode_accelerator.h
+++ b/content/common/gpu/media/mac_video_decode_accelerator.h
@@ -33,6 +33,7 @@ class CONTENT_EXPORT MacVideoDecodeAccelerator
public:
// Does not take ownership of |client| which must outlive |*this|.
MacVideoDecodeAccelerator(media::VideoDecodeAccelerator::Client* client);
+ virtual ~MacVideoDecodeAccelerator();
// Set the OpenGL context to use.
void SetCGLContext(CGLContextObj cgl_context);
@@ -48,7 +49,6 @@ class CONTENT_EXPORT MacVideoDecodeAccelerator
virtual void Destroy() OVERRIDE;
private:
- virtual ~MacVideoDecodeAccelerator();
// Callback for a completed frame.
void OnFrameReady(int32 bitstream_buffer_id,
@@ -85,6 +85,9 @@ class CONTENT_EXPORT MacVideoDecodeAccelerator
// has been processed.
void NotifyInputBufferRead(int input_buffer_id);
+ // Helper for Destroy(), doing all the actual work except for deleting self.
+ void Cleanup();
+
// To expose client callbacks from VideoDecodeAccelerator.
Client* client_;
// C++ wrapper around the Mac VDA API.
« no previous file with comments | « content/common/gpu/media/gpu_video_decode_accelerator.cc ('k') | content/common/gpu/media/mac_video_decode_accelerator.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698