Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 10748011: Fix to problem of chrome.runtime sometimes not being defined. (Closed)

Created:
8 years, 5 months ago by asargent_no_longer_on_chrome
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix to problem of chrome.runtime sometimes not being defined. There appears to be some non-determinism in the order that the chrome.runtime namespace gets set up relative to when the last_error.js file is loaded. This adds a require statement that should hopefully resolve this. BUG=136352 TEST=Chrome webstore should function normally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145964

Patch Set 1 #

Patch Set 2 : less hacky approach #

Total comments: 2

Patch Set 3 : single quotes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/renderer/resources/extensions/last_error.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
asargent_no_longer_on_chrome
8 years, 5 months ago (2012-07-10 19:58:57 UTC) #1
Mihai Parparita -not on Chrome
LGTM http://codereview.chromium.org/10748011/diff/2001/chrome/renderer/resources/extensions/last_error.js File chrome/renderer/resources/extensions/last_error.js (right): http://codereview.chromium.org/10748011/diff/2001/chrome/renderer/resources/extensions/last_error.js#newcode5 chrome/renderer/resources/extensions/last_error.js:5: requireNative("runtime"); Nit: should use single quotes.
8 years, 5 months ago (2012-07-10 20:02:08 UTC) #2
asargent_no_longer_on_chrome
http://codereview.chromium.org/10748011/diff/2001/chrome/renderer/resources/extensions/last_error.js File chrome/renderer/resources/extensions/last_error.js (right): http://codereview.chromium.org/10748011/diff/2001/chrome/renderer/resources/extensions/last_error.js#newcode5 chrome/renderer/resources/extensions/last_error.js:5: requireNative("runtime"); On 2012/07/10 20:02:08, Mihai Parparita wrote: > Nit: ...
8 years, 5 months ago (2012-07-10 20:11:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10748011/7002
8 years, 5 months ago (2012-07-10 20:11:52 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 21:50:22 UTC) #5
Try job failure for 10748011-7002 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698