Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: src/accessors.cc

Issue 10748002: Fix types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 841 matching lines...) Expand 10 before | Expand all | Expand 10 after
852 Handle<String> name, 852 Handle<String> name,
853 int index, 853 int index,
854 PropertyAttributes attributes) { 854 PropertyAttributes attributes) {
855 Factory* factory = name->GetIsolate()->factory(); 855 Factory* factory = name->GetIsolate()->factory();
856 Handle<AccessorInfo> info = factory->NewAccessorInfo(); 856 Handle<AccessorInfo> info = factory->NewAccessorInfo();
857 info->set_property_attributes(attributes); 857 info->set_property_attributes(attributes);
858 info->set_all_can_read(true); 858 info->set_all_can_read(true);
859 info->set_all_can_write(true); 859 info->set_all_can_write(true);
860 info->set_name(*name); 860 info->set_name(*name);
861 info->set_data(Smi::FromInt(index)); 861 info->set_data(Smi::FromInt(index));
862 Handle<Foreign> getter = v8::FromCData(&ModuleGetExport); 862 Handle<Object> getter = v8::FromCData(&ModuleGetExport);
863 Handle<Foreign> setter = v8::FromCData(&ModuleSetExport); 863 Handle<Object> setter = v8::FromCData(&ModuleSetExport);
864 info->set_getter(*getter); 864 info->set_getter(*getter);
865 if (!(attributes & ReadOnly)) info->set_setter(*setter); 865 if (!(attributes & ReadOnly)) info->set_setter(*setter);
866 return info; 866 return info;
867 } 867 }
868 868
869 869
870 } } // namespace v8::internal 870 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698