Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: src/objects.h

Issue 10743003: Splitting DescriptorArray::CopyInsert into CopyInsert and CopyReplace. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/factory.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2551 matching lines...) Expand 10 before | Expand all | Expand 10 after
2562 int src_index, 2562 int src_index,
2563 const WhitenessWitness&); 2563 const WhitenessWitness&);
2564 2564
2565 // Copy the descriptor array, insert a new descriptor and optionally 2565 // Copy the descriptor array, insert a new descriptor and optionally
2566 // remove map transitions. If the descriptor is already present, it is 2566 // remove map transitions. If the descriptor is already present, it is
2567 // replaced. If a replaced descriptor is a real property (not a transition 2567 // replaced. If a replaced descriptor is a real property (not a transition
2568 // or null), its enumeration index is kept as is. 2568 // or null), its enumeration index is kept as is.
2569 // If adding a real property, map transitions must be removed. If adding 2569 // If adding a real property, map transitions must be removed. If adding
2570 // a transition, they must not be removed. All null descriptors are removed. 2570 // a transition, they must not be removed. All null descriptors are removed.
2571 MUST_USE_RESULT MaybeObject* CopyInsert(Descriptor* descriptor); 2571 MUST_USE_RESULT MaybeObject* CopyInsert(Descriptor* descriptor);
2572 MUST_USE_RESULT MaybeObject* CopyAdd(Descriptor* descriptor);
2573 MUST_USE_RESULT MaybeObject* CopyReplace(Descriptor* descriptor,
2574 int insertion_index);
2572 2575
2573 // Indicates whether the search function should expect a sorted or an unsorted 2576 // Indicates whether the search function should expect a sorted or an unsorted
2574 // descriptor array as input. 2577 // descriptor array as input.
2575 enum SharedMode { 2578 enum SharedMode {
2576 MAY_BE_SHARED, 2579 MAY_BE_SHARED,
2577 CANNOT_BE_SHARED 2580 CANNOT_BE_SHARED
2578 }; 2581 };
2579 2582
2580 // Return a copy of the array with all transitions and null descriptors 2583 // Return a copy of the array with all transitions and null descriptors
2581 // removed. Return a Failure object in case of an allocation failure. 2584 // removed. Return a Failure object in case of an allocation failure.
(...skipping 6300 matching lines...) Expand 10 before | Expand all | Expand 10 after
8882 } else { 8885 } else {
8883 value &= ~(1 << bit_position); 8886 value &= ~(1 << bit_position);
8884 } 8887 }
8885 return value; 8888 return value;
8886 } 8889 }
8887 }; 8890 };
8888 8891
8889 } } // namespace v8::internal 8892 } } // namespace v8::internal
8890 8893
8891 #endif // V8_OBJECTS_H_ 8894 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/factory.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698