Splitting DescriptorArray::CopyInsert into CopyInsert and CopyReplace.

src/objects.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2551 matching lines @@
                                         int src_index,
                                         const WhitenessWitness&);
 
   // Copy the descriptor array, insert a new descriptor and optionally
   // remove map transitions.  If the descriptor is already present, it is
   // replaced.  If a replaced descriptor is a real property (not a transition
   // or null), its enumeration index is kept as is.
   // If adding a real property, map transitions must be removed.  If adding
   // a transition, they must not be removed.  All null descriptors are removed.
   MUST_USE_RESULT MaybeObject* CopyInsert(Descriptor* descriptor);
+  MUST_USE_RESULT MaybeObject* CopyAdd(Descriptor* descriptor);
+  MUST_USE_RESULT MaybeObject* CopyReplace(
+      int insertion_index, Descriptor* descriptor);

[Michael Starzinger, 2012/07/12 13:17:42]

To me it seems more intuitive to switch those two arguments, first the
descriptor, then the insertion_index. But I'll leave the final decision up to
you.

Also can we have the linebreak after the "," to be consistent with the other
declarations.

 
   // Indicates whether the search function should expect a sorted or an unsorted
   // descriptor array as input.
   enum SharedMode {
     MAY_BE_SHARED,
     CANNOT_BE_SHARED
   };
 
   // Return a copy of the array with all transitions and null descriptors
   // removed. Return a Failure object in case of an allocation failure.
@@ skipping 6300 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_