Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 10743002: Fix fade-truncation of LTR tab titles under RTL UI. (Closed)

Created:
8 years, 5 months ago by Alexei Svitkine (slow)
Modified:
8 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews
Visibility:
Public.

Description

Fix fade-truncation of LTR tab titles under RTL UI. This was regressed by http://crrev.com/145435, which made UpdateRenderText() get a default alignment based on the UI directionality in the case where |flags| didn't specify one. This caused an issue for DrawFadeTruncatingString(), which assumed that the default alignment would LTR unless specified otherwise. This CL fixes the issue by having DrawFadeTruncatingString() specify LTR alignment whenever it doesn't explicitly set it to RTL, which matches its behavior before r145435. BUG=135639 TEST=Open chrome.exe --lang=he and go to amazon.com. The tab title, which should be in English, should be fade truncated on the right end. Go to http://www.haaretz.co.il and text should be fade truncated on the left end. When launched in LTR mode (chrome.exe --lang=en), both of those tab titles should be fade-truncated on right, per the M19 behavior. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/gfx/canvas_skia.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
8 years, 5 months ago (2012-07-09 15:19:49 UTC) #1
msw
LGTM, but I think we should clean up the directionality and alignment code sometime soon, ...
8 years, 5 months ago (2012-07-09 18:22:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10743002/1
8 years, 5 months ago (2012-07-09 18:23:13 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-09 19:51:44 UTC) #4
Change committed as 145727

Powered by Google App Engine
This is Rietveld 408576698