Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: crypto/mock_keychain_mac.cc

Issue 10738003: src/crypto should build on the x86_64 architecture. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: used typedefs (to uintptr_t) for keys and items. changed password_data_count_'s type to int. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« crypto/mock_keychain_mac.h ('K') | « crypto/mock_keychain_mac.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crypto/mock_keychain_mac.cc
===================================================================
--- crypto/mock_keychain_mac.cc (revision 145645)
+++ crypto/mock_keychain_mac.cc (working copy)
@@ -17,7 +17,7 @@
called_add_generic_(false),
password_data_count_(0) {}
-void MockKeychain::InitializeKeychainData(unsigned int key) const {
+void MockKeychain::InitializeKeychainData(MockKeychainKeyType key) const {
UInt32 tags[] = { kSecAccountItemAttr,
kSecServerItemAttr,
kSecPortItemAttr,
@@ -61,7 +61,7 @@
}
MockKeychain::~MockKeychain() {
- for (std::map<unsigned int, SecKeychainAttributeList>::iterator it =
+ for (std::map<MockKeychainKeyType, SecKeychainAttributeList>::iterator it =
keychain_attr_list_.begin(); it != keychain_attr_list_.end(); ++it) {
for (unsigned int i = 0; i < it->second.count; ++i) {
if (it->second.attr[i].data)
@@ -92,7 +92,7 @@
return &(attribute_list.attr[attribute_index]);
}
-void MockKeychain::SetTestDataBytes(int item,
+void MockKeychain::SetTestDataBytes(MockKeychainItemType item,
UInt32 tag,
const void* data,
size_t length) {
@@ -110,25 +110,31 @@
}
}
-void MockKeychain::SetTestDataString(int item, UInt32 tag, const char* value) {
+void MockKeychain::SetTestDataString(
+ MockKeychainItemType item,
+ UInt32 tag,
+ const char* value) {
SetTestDataBytes(item, tag, value, value ? strlen(value) : 0);
}
-void MockKeychain::SetTestDataPort(int item, UInt32 value) {
+void MockKeychain::SetTestDataPort(MockKeychainItemType item, UInt32 value) {
SecKeychainAttribute* attribute = AttributeWithTag(keychain_attr_list_[item],
kSecPortItemAttr);
UInt32* data = static_cast<UInt32*>(attribute->data);
*data = value;
}
-void MockKeychain::SetTestDataProtocol(int item, SecProtocolType value) {
+void MockKeychain::SetTestDataProtocol(MockKeychainItemType item,
+ SecProtocolType value) {
SecKeychainAttribute* attribute = AttributeWithTag(keychain_attr_list_[item],
kSecProtocolItemAttr);
SecProtocolType* data = static_cast<SecProtocolType*>(attribute->data);
*data = value;
}
-void MockKeychain::SetTestDataAuthType(int item, SecAuthenticationType value) {
+void MockKeychain::SetTestDataAuthType(
+ MockKeychainItemType item,
+ SecAuthenticationType value) {
SecKeychainAttribute* attribute = AttributeWithTag(
keychain_attr_list_[item], kSecAuthenticationTypeItemAttr);
SecAuthenticationType* data = static_cast<SecAuthenticationType*>(
@@ -136,21 +142,23 @@
*data = value;
}
-void MockKeychain::SetTestDataNegativeItem(int item, Boolean value) {
+void MockKeychain::SetTestDataNegativeItem(MockKeychainItemType item,
+ Boolean value) {
SecKeychainAttribute* attribute = AttributeWithTag(keychain_attr_list_[item],
kSecNegativeItemAttr);
Boolean* data = static_cast<Boolean*>(attribute->data);
*data = value;
}
-void MockKeychain::SetTestDataCreator(int item, OSType value) {
+void MockKeychain::SetTestDataCreator(MockKeychainItemType item, OSType value) {
SecKeychainAttribute* attribute = AttributeWithTag(keychain_attr_list_[item],
kSecCreatorItemAttr);
OSType* data = static_cast<OSType*>(attribute->data);
*data = value;
}
-void MockKeychain::SetTestDataPasswordBytes(int item, const void* data,
+void MockKeychain::SetTestDataPasswordBytes(MockKeychainItemType item,
+ const void* data,
size_t length) {
keychain_data_[item].length = length;
if (length > 0) {
@@ -163,7 +171,9 @@
}
}
-void MockKeychain::SetTestDataPasswordString(int item, const char* value) {
+void MockKeychain::SetTestDataPasswordString(
+ MockKeychainItemType item,
+ const char* value) {
SetTestDataPasswordBytes(item, value, value ? strlen(value) : 0);
}
@@ -175,7 +185,7 @@
UInt32* length,
void** outData) const {
DCHECK(itemRef);
- unsigned int key = reinterpret_cast<unsigned int>(itemRef) - 1;
+ MockKeychainKeyType key = reinterpret_cast<MockKeychainKeyType>(itemRef) - 1;
if (keychain_attr_list_.find(key) == keychain_attr_list_.end())
return errSecInvalidItemRef;
@@ -204,7 +214,7 @@
return errSecAuthFailed;
}
- unsigned int key = reinterpret_cast<unsigned int>(itemRef) - 1;
+ MockKeychainKeyType key = reinterpret_cast<MockKeychainKeyType>(itemRef) - 1;
if (keychain_attr_list_.find(key) == keychain_attr_list_.end())
return errSecInvalidItemRef;
@@ -232,7 +242,7 @@
}
OSStatus MockKeychain::ItemDelete(SecKeychainItemRef itemRef) const {
- unsigned int key = reinterpret_cast<unsigned int>(itemRef) - 1;
+ MockKeychainKeyType key = reinterpret_cast<MockKeychainKeyType>(itemRef) - 1;
for (unsigned int i = 0; i < keychain_attr_list_[key].count; ++i) {
if (keychain_attr_list_[key].attr[i].data)
@@ -256,8 +266,9 @@
// Figure out which of our mock items matches, and set up the array we'll use
// to generate results out of SearchCopyNext.
remaining_search_results_.clear();
- for (std::map<unsigned int, SecKeychainAttributeList>::const_iterator it =
- keychain_attr_list_.begin(); it != keychain_attr_list_.end(); ++it) {
+ for (std::map<MockKeychainKeyType, SecKeychainAttributeList>
+ ::const_iterator it = keychain_attr_list_.begin();
+ it != keychain_attr_list_.end(); ++it) {
bool mock_item_matches = true;
for (UInt32 search_attr = 0; search_attr < attrList->count; ++search_attr) {
SecKeychainAttribute* mock_attribute =
@@ -291,8 +302,9 @@
UInt16 port,
SecProtocolType protocol,
SecAuthenticationType authenticationType) const {
- for (std::map<unsigned int, SecKeychainAttributeList>::const_iterator it =
- keychain_attr_list_.begin(); it != keychain_attr_list_.end(); ++it) {
+ for (std::map<MockKeychainKeyType, SecKeychainAttributeList>
+ ::const_iterator it = keychain_attr_list_.begin();
+ it != keychain_attr_list_.end(); ++it) {
SecKeychainAttribute* attribute;
attribute = AttributeWithTag(it->second, kSecServerItemAttr);
if ((attribute->length != serverNameLength) ||
@@ -385,7 +397,7 @@
}
// Pick the next unused slot.
- unsigned int key = next_item_key_++;
+ MockKeychainKeyType key = next_item_key_++;
// Initialize keychain data storage at the target location.
InitializeKeychainData(key);
@@ -424,7 +436,7 @@
SecKeychainItemRef* itemRef) const {
if (remaining_search_results_.empty())
return errSecItemNotFound;
- unsigned int key = remaining_search_results_.front();
+ MockKeychainKeyType key = remaining_search_results_.front();
remaining_search_results_.erase(remaining_search_results_.begin());
*itemRef = reinterpret_cast<SecKeychainItemRef>(key + 1);
++keychain_item_copy_count_;
@@ -483,7 +495,7 @@
if (!ref)
return;
- if (reinterpret_cast<int>(ref) == kDummySearchRef) {
+ if (reinterpret_cast<MockKeychainKeyType>(ref) == kDummySearchRef) {
--search_copy_count_;
} else {
--keychain_item_copy_count_;
@@ -503,7 +515,7 @@
}
bool MockKeychain::CreatorCodesSetForAddedItems() const {
- for (std::set<unsigned int>::const_iterator i = added_via_api_.begin();
+ for (std::set<MockKeychainKeyType>::const_iterator i = added_via_api_.begin();
i != added_via_api_.end(); ++i) {
SecKeychainAttribute* attribute = AttributeWithTag(keychain_attr_list_[*i],
kSecCreatorItemAttr);
@@ -515,7 +527,7 @@
}
void MockKeychain::AddTestItem(const KeychainTestData& item_data) {
- unsigned int key = next_item_key_++;
+ MockKeychainKeyType key = next_item_key_++;
InitializeKeychainData(key);
SetTestDataAuthType(key, item_data.auth_type);
@@ -531,4 +543,4 @@
SetTestDataNegativeItem(key, item_data.negative_item);
}
-} // namespace crypto
+} // namespace crypto
« crypto/mock_keychain_mac.h ('K') | « crypto/mock_keychain_mac.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698