src/crypto should build on the x86_64 architecture.

crypto/mock_keychain_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CRYPTO_MOCK_KEYCHAIN_MAC_H_
 #define CRYPTO_MOCK_KEYCHAIN_MAC_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 132 matching lines @@
       UInt32 securityDomainLength,
       const char* securityDomain,
       UInt32 accountNameLength,
       const char* accountName,
       UInt32 pathLength,
       const char* path,
       UInt16 port,
       SecProtocolType protocol,
       SecAuthenticationType authenticationType) const;
   // Initializes storage for keychain data at |key|.
-  void InitializeKeychainData(unsigned int key) const;
+  void InitializeKeychainData(uintptr_t key) const;
   // Sets the data and length of |tag| in the item-th test item.
-  void SetTestDataBytes(int item, UInt32 tag, const void* data, size_t length);
+  void SetTestDataBytes(
+      uintptr_t item,
+      UInt32 tag,
+      const void* data,
+      size_t length);
   // Sets the data and length of |tag| in the item-th test item based on
   // |value|. The null-terminator will not be included; the Keychain Services
   // docs don't indicate whether it is or not, so clients should not assume
   // that it will be.
-  void SetTestDataString(int item, UInt32 tag, const char* value);
+  void SetTestDataString(uintptr_t item, UInt32 tag, const char* value);
   // Sets the data of the corresponding attribute of the item-th test item to
   // |value|. Assumes that the space has alread been allocated, and the length
   // set.
-  void SetTestDataPort(int item, UInt32 value);
-  void SetTestDataProtocol(int item, SecProtocolType value);
-  void SetTestDataAuthType(int item, SecAuthenticationType value);
-  void SetTestDataNegativeItem(int item, Boolean value);
-  void SetTestDataCreator(int item, OSType value);
+  void SetTestDataPort(uintptr_t item, UInt32 value);
+  void SetTestDataProtocol(uintptr_t item, SecProtocolType value);
+  void SetTestDataAuthType(uintptr_t item, SecAuthenticationType value);
+  void SetTestDataNegativeItem(uintptr_t item, Boolean value);
+  void SetTestDataCreator(uintptr_t item, OSType value);
   // Sets the password data and length for the item-th test item.
-  void SetTestDataPasswordBytes(int item, const void* data, size_t length);
+  void SetTestDataPasswordBytes(
+      uintptr_t item,
+      const void* data,
+      size_t length);
   // Sets the password for the item-th test item. As with SetTestDataString,
   // the data will not be null-terminated.
-  void SetTestDataPasswordString(int item, const char* value);
+  void SetTestDataPasswordString(uintptr_t item, const char* value);
 
   // Returns the address of the attribute in attribute_list with tag |tag|.
   static SecKeychainAttribute* AttributeWithTag(
       const SecKeychainAttributeList& attribute_list,
       UInt32 tag);
 
-  static const int kDummySearchRef = 1000;
+  static const uintptr_t kDummySearchRef = 1000;
 
   typedef struct KeychainPasswordData {
     KeychainPasswordData() : data(NULL), length(0) {}
     void* data;
     UInt32 length;
   } KeychainPasswordData;
 
   // Mutable because the MockKeychain API requires its internal keychain storage
   // to be modifiable by users of this class.
-  mutable std::map<unsigned int, SecKeychainAttributeList> keychain_attr_list_;
-  mutable std::map<unsigned int, KeychainPasswordData> keychain_data_;
-  mutable unsigned int next_item_key_;
+  mutable std::map<uintptr_t, SecKeychainAttributeList> keychain_attr_list_;
+  mutable std::map<uintptr_t, KeychainPasswordData> keychain_data_;
+  mutable uintptr_t next_item_key_;
 
   // Tracks the items that should be returned in subsequent calls to
   // SearchCopyNext, based on the last call to SearchCreateFromAttributes.
   // We can't handle multiple active searches, since we don't track the search
   // ref we return, but we don't need to for our mocking.
-  mutable std::vector<unsigned int> remaining_search_results_;
+  mutable std::vector<uintptr_t> remaining_search_results_;
 
   // Track copies and releases to make sure they balance. Really these should
   // be maps to track per item, but this should be good enough to catch
   // real mistakes.
   mutable int search_copy_count_;
   mutable int keychain_item_copy_count_;
   mutable int attribute_data_copy_count_;
 
   // Tracks which items (by key) were added with AddInternetPassword.
   mutable std::set<unsigned int> added_via_api_;

[wtc, 2012/07/18 19:03:16]

This should also be changed to uintptr_t (or the
MockKeychainItemType typedef that mark suggested).

[Mihai Maerean, 2012/07/19 11:33:26]

True, added_via_api_ uses the same keys as keychain_attr_list_.

On 2012/07/18 19:03:16, wtc wrote:

 
   // Result code for the |FindGenericPassword()| method.
   OSStatus find_generic_result_;
 
   // Records whether |AddGenericPassword()| gets called.
   mutable bool called_add_generic_;
 
   // Tracks the allocations and frees of password data in |FindGenericPassword|
   // and |ItemFreeContent|.
   mutable unsigned int password_data_count_;

[wtc, 2012/07/18 19:03:16]

This should be "int".  It is not used by this class
internally.  It is exposed via the password_data_count()
getter, which returns "int".

[Mihai Maerean, 2012/07/19 11:33:26]

Ok, I will change the type to int (although this should be committed as a
different patch than this).

On 2012/07/18 19:03:16, wtc wrote:

[wtc, 2012/07/19 17:59:26]

You're right.  I will make this change in
https://chromiumcodereview.appspot.com/10800038/

 
   // Records the password being set when |AddGenericPassword()| gets called.
   mutable std::string add_generic_password_;
 };
 
 }  // namespace crypto
 
 #endif  // CRYPTO_MOCK_KEYCHAIN_MAC_H_