Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7505)

Unified Diff: chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc

Issue 10736066: Adding histograms showing fraction of page load times (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/cache_stats.cc ('k') | chrome/browser/net/chrome_network_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc
===================================================================
--- chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc (revision 148459)
+++ chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc (working copy)
@@ -121,7 +121,7 @@
// This class doesn't do anything now, but in near future versions it will.
class MockURLRequest : public net::URLRequest {
public:
- MockURLRequest(net::URLRequestContext* context)
+ explicit MockURLRequest(net::URLRequestContext* context)
: net::URLRequest(GURL(""), NULL, context) {
}
@@ -152,21 +152,24 @@
};
static void DoReportIsSent() {
- ChromeURLRequestContext context;
+ ChromeURLRequestContext context(ChromeURLRequestContext::CONTEXT_TYPE_MAIN,
+ NULL);
SendingTestReporter reporter(&context);
SSLInfo info = GetGoodSSLInfo();
reporter.SendReport("mail.google.com", info, true);
}
static void DoReportIsNotSent() {
- ChromeURLRequestContext context;
+ ChromeURLRequestContext context(ChromeURLRequestContext::CONTEXT_TYPE_MAIN,
+ NULL);
NotSendingTestReporter reporter(&context);
SSLInfo info = GetBadSSLInfo();
reporter.SendReport("www.example.com", info, true);
}
static void DoMockReportIsSent() {
- ChromeURLRequestContext context;
+ ChromeURLRequestContext context(ChromeURLRequestContext::CONTEXT_TYPE_MAIN,
+ NULL);
MockReporter reporter(&context);
SSLInfo info = GetGoodSSLInfo();
reporter.SendReport("mail.google.com", info, true);
« no previous file with comments | « chrome/browser/net/cache_stats.cc ('k') | chrome/browser/net/chrome_network_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698