Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 10736065: Disable building unit_tests.exe on DrMemory builders. (Closed)

Created:
8 years, 5 months ago by Hironori Bono
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Disable building unit_tests.exe on DrMemory builders. The "Chromium Windows Builder (DrMemory)" bot runs out of memory when link.exe creates unit_test.exe because DrMemory needs static builds. This change just disables building unit_tests.exe as a better-than-nothing workaround. BUG=137180 TEST=make the "Chromium Windows Builder (DrMemory)" bot green. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Hironori Bono
8 years, 5 months ago (2012-07-13 03:02:20 UTC) #1
Timur Iskhodzhanov
LGTM as a short-term solution
8 years, 5 months ago (2012-07-13 08:21:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10736065/1
8 years, 5 months ago (2012-07-13 08:36:14 UTC) #3
commit-bot: I haz the power
Try job failure for 10736065-1 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-13 09:43:08 UTC) #4
Timur Iskhodzhanov
Why can't I CQ again?..
8 years, 5 months ago (2012-07-13 11:21:15 UTC) #5
Hironori Bono
8 years, 5 months ago (2012-07-13 11:31:53 UTC) #6
Greetings Timur,

Sorry for bothering you. I have landed this change manually so the "Chromium
Windows Builder (DrMemory)" bot can get it as soon as possible.

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698