Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 10736062: Don't close pending user gesture when PluginInstance receives ACKs for input events. (Closed)

Created:
8 years, 5 months ago by yzshen1
Modified:
8 years, 5 months ago
Reviewers:
bbudge
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Don't close pending user gesture when PluginInstance receives ACKs for input events. Because plugins might respond to input events asynchronously. We just wait until kUserGestureDurationInSeconds expires. BUG=134959 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yzshen1
Hi, Bill. Would you please take a look? I didn't remove code for closing pending ...
8 years, 5 months ago (2012-07-13 00:50:52 UTC) #1
bbudge
LGTM
8 years, 5 months ago (2012-07-13 01:08:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/10736062/1
8 years, 5 months ago (2012-07-13 02:16:05 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-13 03:27:53 UTC) #4
Change committed as 146513

Powered by Google App Engine
This is Rietveld 408576698