Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 10736061: Enable debug logging for views::View (Closed)

Created:
8 years, 5 months ago by dhollowa
Modified:
8 years, 5 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, tfarina, mazda+watch_chromium.org
Visibility:
Public.

Description

Enable debug logging for views::View Enables the alt-ctrl-shift-V accelerator for dumping views::View hierarchy to console. BUG=none TEST=Bring up Aura build on Linux, type alt-ctrl-shift-V and check logs. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146575

Patch Set 1 #

Patch Set 2 : Compile glitch in release #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M ash/accelerators/accelerator_controller.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/views/debug_utils.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/debug_utils.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dhollowa
8 years, 5 months ago (2012-07-13 00:11:35 UTC) #1
Ben Goodger (Google)
LGTM... and thanks for the chips!
8 years, 5 months ago (2012-07-13 00:40:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10736061/1007
8 years, 5 months ago (2012-07-13 01:16:59 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-13 02:30:52 UTC) #4
Try job failure for 10736061-1007 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698