remoting/base/dispatch_win.h.pump - Issue 10736059: Add support of DISPATCH_PROPERTYPUT and DISPATCH_PROPERTYPUTREF to remoting::dispatch::Invoke().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/base/dispatch_win.h.pump

Issue 10736059: Add support of DISPATCH_PROPERTYPUT and DISPATCH_PROPERTYPUTREF to remoting::dispatch::Invoke(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/base/dispatch_win.h.pump

diff --git a/remoting/base/dispatch_win.h.pump b/remoting/base/dispatch_win.h.pump

index 57439e531d76b68de5120b32ab3f2b8c06ec8d5b..51ca54f8ebc1e9f8da9e7a3a501f394342113014 100644

--- a/remoting/base/dispatch_win.h.pump

+++ b/remoting/base/dispatch_win.h.pump

@@ -170,6 +170,13 @@ $if ARITY > 0 [[

DISPPARAMS disp_params = { NULL, NULL, 0, 0 };

]]

+ // DISPATCH_PROPERTYPUT and DISPATCH_PROPERTYPUTREF require special handling.

Wez 2012/07/12 22:26:15 nit: Put this in the comment above, after "Invoke

Wez 2012/07/12 22:26:15 Can you clarify what "special handling" means; you

alexeypa (please no reviews) 2012/07/12 23:16:52 Done.

+ DISPID dispid_named = DISPID_PROPERTYPUT;

+ if (flags == DISPATCH_PROPERTYPUT || flags == DISPATCH_PROPERTYPUTREF) {

+ disp_params.cNamedArgs = 1;

+ disp_params.rgdispidNamedArgs = &dispid_named;

+ }

hr = object->Invoke(disp_id, IID_NULL, LOCALE_USER_DEFAULT, flags,

&disp_params, disp_result, NULL, NULL);

if (FAILED(hr))

« no previous file with comments | « remoting/base/dispatch_win.h ('k') | no next file » | no next file with comments »