Add support of DISPATCH_PROPERTYPUT and DISPATCH_PROPERTYPUTREF to remoting::dispatch::Invoke().

Added support of DISPATCH_PROPERTYPUT and DISPATCH_PROPERTYPUTREF to remoting::dispatch::Invoke().

According to MSDN (http://msdn.microsoft.com/en-us/library/windows/desktop/ms221479(v=vs.85).aspx) when IDispatch::Invoke() is used with DISPATCH_PROPERTYPUT or DISPATCH_PROPERTYPUTREF, the property setter's parameter must be named.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147106

[alexeypa (please no reviews), 2012-07-12 22:17:21]

Please take a look.

[Wez, 2012-07-12 22:26:15]

https://chromiumcodereview.appspot.com/10736059/diff/1/remoting/base/dispatch...
File remoting/base/dispatch_win.h.pump (right):

https://chromiumcodereview.appspot.com/10736059/diff/1/remoting/base/dispatch...
remoting/base/dispatch_win.h.pump:173: // DISPATCH_PROPERTYPUT and
DISPATCH_PROPERTYPUTREF require special handling.
nit: Put this in the comment above, after "Invoke the method."

https://chromiumcodereview.appspot.com/10736059/diff/1/remoting/base/dispatch...
remoting/base/dispatch_win.h.pump:173: // DISPATCH_PROPERTYPUT and
DISPATCH_PROPERTYPUTREF require special handling.
Can you clarify what "special handling" means; you appear to be adding a single
named parameter to the Invoke() call?

[alexeypa (please no reviews), 2012-07-12 23:16:52]

FYI

https://chromiumcodereview.appspot.com/10736059/diff/1/remoting/base/dispatch...
File remoting/base/dispatch_win.h.pump (right):

https://chromiumcodereview.appspot.com/10736059/diff/1/remoting/base/dispatch...
remoting/base/dispatch_win.h.pump:173: // DISPATCH_PROPERTYPUT and
DISPATCH_PROPERTYPUTREF require special handling.
On 2012/07/12 22:26:15, Wez wrote:
> nit: Put this in the comment above, after "Invoke the method."

Done.

https://chromiumcodereview.appspot.com/10736059/diff/1/remoting/base/dispatch...
remoting/base/dispatch_win.h.pump:173: // DISPATCH_PROPERTYPUT and
DISPATCH_PROPERTYPUTREF require special handling.
On 2012/07/12 22:26:15, Wez wrote:
> Can you clarify what "special handling" means; you appear to be adding a
single
> named parameter to the Invoke() call?

Done.

[alexeypa (please no reviews), 2012-07-17 17:15:42]

Ping?

[Wez, 2012-07-17 19:53:23]

https://chromiumcodereview.appspot.com/10736059/diff/5001/remoting/base/dispa...
File remoting/base/dispatch_win.h.pump (right):

https://chromiumcodereview.appspot.com/10736059/diff/5001/remoting/base/dispa...
remoting/base/dispatch_win.h.pump:166: // the parameter to be named, so
|cNamedArgs| and |rgdispidNamedArgs| should
Which parameter are you referring to here?

[alexeypa (please no reviews), 2012-07-17 19:58:12]

https://chromiumcodereview.appspot.com/10736059/diff/5001/remoting/base/dispa...
File remoting/base/dispatch_win.h.pump (right):

https://chromiumcodereview.appspot.com/10736059/diff/5001/remoting/base/dispa...
remoting/base/dispatch_win.h.pump:166: // the parameter to be named, so
|cNamedArgs| and |rgdispidNamedArgs| should
On 2012/07/17 19:53:24, Wez wrote:
> Which parameter are you referring to here?

The parameter of a property setter. DISPATCH_PROPERTYPUT and
DISPATCH_PROPERTYPUTREF are telling us that it is a property setter that is
being called.

I'm guessing (it is not clearly documented) a property setter always has only
one parameter. I believe it does not make sense to check if |ARITY| != 1 in
here. IDispatch::Invoke will do it for us.

[Wez, 2012-07-17 20:12:53]

lgtm

[Wez, 2012-07-17 20:13:33]

On 2012/07/17 19:58:12, alexeypa wrote:
>
https://chromiumcodereview.appspot.com/10736059/diff/5001/remoting/base/dispa...
> File remoting/base/dispatch_win.h.pump (right):
> 
>
https://chromiumcodereview.appspot.com/10736059/diff/5001/remoting/base/dispa...
> remoting/base/dispatch_win.h.pump:166: // the parameter to be named, so
> |cNamedArgs| and |rgdispidNamedArgs| should
> On 2012/07/17 19:53:24, Wez wrote:
> > Which parameter are you referring to here?
> 
> The parameter of a property setter. DISPATCH_PROPERTYPUT and
> DISPATCH_PROPERTYPUTREF are telling us that it is a property setter that is
> being called.
> 
> I'm guessing (it is not clearly documented) a property setter always has only
> one parameter. I believe it does not make sense to check if |ARITY| != 1 in
> here. IDispatch::Invoke will do it for us.

OK; consider updating the comment to clarify that, if you're reasonably
confident that that's the case.

[commit-bot: I haz the power, 2012-07-17 20:32:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10736059/10001

[commit-bot: I haz the power, 2012-07-17 22:24:49]

Change committed as 147106