Smoke test for tracing infrastructure in PyAuto

chrome/test/functional/tracing/tracing_smoke_test.py

+#!/usr/bin/env python
+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import unittest
+
+import pyauto_tracing
+import pyauto
+import tracer
+

[Nirnimesh, 2012/07/30 21:03:51]

Need 2 blank lines at global scope

+class TracingSmokeTest(pyauto.PyUITest):

[Nirnimesh, 2012/07/30 21:03:51]

Docstring please

+  def setUp(self):
+    super(TracingSmokeTest, self).setUp()
+    self._tracer_factory = tracer.TracerFactory(self)
+
+  def testGetData(self):

[Nirnimesh, 2012/07/30 21:03:51]

Docstring plz.

This is the text that'll get printed out when the test runs.
If you don't have anything, it prints "None" which doesn't look good.

+    tracer = self._tracer_factory.Produce()
+    tracer.BeginTracing()
+    model = tracer.EndTracing()
+    self.assertEqual(1, len(model.FindAllThreadsNamed("CrBrowserMain")))
+
+  def testMultipleTraces(self):
+    tracer = self._tracer_factory.Produce()
+    tracer.BeginTracing()
+    model1 = tracer.EndTracing()
+    tracer.BeginTracing()
+    model2 = tracer.EndTracing()
+    del tracer
+    self.assertEqual(1, len(model1.FindAllThreadsNamed("CrBrowserMain")))

[Nirnimesh, 2012/07/30 21:03:51]

use ' instead of "

+    self.assertEqual(1, len(model2.FindAllThreadsNamed("CrBrowserMain")))
+
+  def testMultipleTracers(self):
+    tracer1 = self._tracer_factory.Produce()
+    tracer2 = self._tracer_factory.Produce()
+    del self._tracer_factory
+    # I don't know what will happen if you try to nest calls to beginTracing.
+    tracer1.BeginTracing()
+    model1 = tracer1.EndTracing()
+    del tracer1
+    tracer2.BeginTracing()
+    model2 = tracer2.EndTracing()
+    del tracer2
+    self.assertEqual(1, len(model1.FindAllThreadsNamed("CrBrowserMain")))
+    del model1
+    self.assertEqual(1, len(model2.FindAllThreadsNamed("CrBrowserMain")))
+    del model2
+

[Nirnimesh, 2012/07/30 21:03:51]

add another blank line here

+if __name__ == '__main__':
+  pyauto_tracing.Main()