Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 10736049: Android: move functions added in third_party to android_commands. (Closed)

Created:
8 years, 5 months ago by bulach
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android: move functions added in third_party to android_commands. Following http://codereview.chromium.org/10692132. That patch effectively forked adb_interface.py under third_party. We already have our android_commands.py wrapper, so let's use that and avoid forking. BUG= TEST=./build/android/run_tests.py -s out/Release/base_unittests_apk/base_unittests-debug.apk -e 1 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146557

Patch Set 1 #

Patch Set 2 : Only restart adb server if running on emulator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -55 lines) Patch
M build/android/emulator.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/android_commands.py View 1 chunk +50 lines, -0 lines 0 comments Download
M build/android/pylib/single_test_runner.py View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/android_testrunner/README.chromium View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/android_testrunner/adb_interface.py View 2 chunks +0 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
No functional changes here, just moving the code one level up to avoid forking.
8 years, 5 months ago (2012-07-12 15:52:00 UTC) #1
bulach
sorry, previous comment was only valid for patchset 1. for patchset 2, it will only ...
8 years, 5 months ago (2012-07-12 16:25:59 UTC) #2
John Grabowski
LGTM
8 years, 5 months ago (2012-07-12 18:41:10 UTC) #3
Wei James(wistoch)
thanks for fixing it.
8 years, 5 months ago (2012-07-13 01:19:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10736049/3001
8 years, 5 months ago (2012-07-13 09:13:28 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-13 11:12:00 UTC) #6
Change committed as 146557

Powered by Google App Engine
This is Rietveld 408576698