Issue 10736048: Fix check_perms following http://codereview.chromium.org/10703165/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10736048: Fix check_perms following http://codereview.chromium.org/10703165/. (Closed)

Created:
8 years, 5 months ago by bulach

Modified:
8 years, 5 months ago

Reviewers:
John Knottenbelt, Jói

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix check_perms following http://codereview.chromium.org/10703165/. A few files were upstreamed with +x, remove the executable bit. BUG= TEST=check_perms is green. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146341

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-2 lines, --2 lines)			Patch
	A	build/android/pylib/run_java_tests.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	A	build/android/pylib/run_python_tests.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 3 (0 generated)

Jói

LGTM On Thu, Jul 12, 2012 at 2:29 PM, <bulach@chromium.org> wrote: > Reviewers: Jói, John ...

8 years, 5 months ago (2012-07-12 14:30:39 UTC) #2

lgtm. Good spot!