Add DPI information to video packets.

remoting/proto/video.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Protocol for video messages.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
@@ skipping 15 matching lines @@
   // Width, height (in screen pixels) for this update.
   optional int32 width = 3;
   optional int32 height = 4;
 
   // The encoding used for this image update.
   optional Encoding encoding = 5 [default = ENCODING_INVALID];
   
   // Width and height of the whole screen.
   optional int32 screen_width = 6;
   optional int32 screen_height = 7;
+
+  // Horizontal and vertical DPI of the screen. If either of these is zero or

[Wez, 2012/07/13 21:49:02]

nit: Rather than complicate calling code, mandate that they be unset or
non-zero?

[Jamie, 2012/07/13 22:17:13]

Does it complicate calling code? If the field is unset, won't the accessor
return zero? So if the caller has to cope with unset, it's actually simpler to
handle zero the same way (no need to call the has_ method).

[Wez, 2012/07/14 00:55:11]

I think that's defined by the protobuf spec, yes, in which case it makes sense
to allow zero values, yes.

+  // unset, the corresponding DPI should be assumed to be 96.

[Wez, 2012/07/13 21:49:02]

nit: It appears that Mac OS X defaults to 72dpi; my suggestion of 96 was based
on what I believe Windows assumes, so we should clarify where 96 comes from!

[Jamie, 2012/07/13 22:17:13]

Assuming most hosts are Windows, let's stick with 96 as the default, but I've
added a comment to clarify why.

+  optional int32 horizontal_dpi = 8;

[Wez, 2012/07/13 21:49:02]

nit: I think x_dpi and y_dpi would be sufficiently clear to the educated reader,
less to type, and would match the naming of the fields in SkIPoint that you've
used to carry DPI in CaptureData.

[Jamie, 2012/07/13 22:17:13]

Done.

+  optional int32 vertical_dpi = 9;
 }
 
 // TODO(hclam): Remove this message once we can obtain dirty rects from libvpx.
 message Rect {
   optional int32 x = 1;
   optional int32 y = 2;
   optional int32 width = 3;
   optional int32 height = 4;
 }
 
@@ skipping 42 matching lines @@
   // Time in milliseconds spent in capturing this video frame.
   optional int32 capture_time_ms = 7;
 
   // Time in milliseconds spent in encoding this video frame.
   optional int32 encode_time_ms = 8;
 
   // The most recent sequence number received from the client on the event
   // channel.
   optional int64 client_sequence_number = 9;
 }