Add DPI information to video packets.

remoting/base/encoder_vp8.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/base/encoder_vp8.h"
 
 #include "base/logging.h"
 #include "base/sys_info.h"
 #include "media/base/yuv_convert.h"
 #include "remoting/base/capture_data.h"
@@ skipping 275 matching lines @@
   }
 
   // Construct the VideoPacket message.
   packet->mutable_format()->set_encoding(VideoPacketFormat::ENCODING_VP8);
   packet->set_flags(VideoPacket::FIRST_PACKET | VideoPacket::LAST_PACKET |
                      VideoPacket::LAST_PARTITION);
   packet->mutable_format()->set_screen_width(capture_data->size().width());
   packet->mutable_format()->set_screen_height(capture_data->size().height());
   packet->set_capture_time_ms(capture_data->capture_time_ms());
   packet->set_client_sequence_number(capture_data->client_sequence_number());
+  SkIPoint dpi(capture_data->dpi());
+  packet->mutable_format()->set_horizontal_dpi(dpi.x());

[Wez, 2012/07/13 21:49:02]

Only set these if dpi() is non-zero, otherwise the current Capturers will result
in zero DPI appearing on the wire.

[Jamie, 2012/07/13 22:17:13]

Done.

On a related note, since both encoders share code to copy fields from
CaptureData to VideoPacket, how would you feel about moving that code into a
CaptureData::CopyToVideoPacket method, probably as a separate CL?

[Wez, 2012/07/14 00:55:11]

In principle that's a layering violation since CaptureData is in base/ and
VideoPacket in protocol/ but clearly we're already violating that layering
here... Capturer, CaptureDate, Encoder & the implementations should move to
host/, really.

But yes, pulling out the initialise-from-CaptureData-fields code makes sense.

+  packet->mutable_format()->set_vertical_dpi(dpi.y());
   for (SkRegion::Iterator r(updated_region); !r.done(); r.next()) {
     Rect* rect = packet->add_dirty_rects();
     rect->set_x(r.rect().x());
     rect->set_y(r.rect().y());
     rect->set_width(r.rect().width());
     rect->set_height(r.rect().height());
   }
 
   data_available_callback.Run(packet.Pass());
 }
 
 }  // namespace remoting